[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [V2] xen-netback notify DomU to send ARP.

>>> On 21.01.13 at 08:26, jianhai luan <jianhai.luan@xxxxxxxxxx> wrote:
>+static void notify_front_arping(struct xenbus_device *dev)
>+      int err;
>+      if (dev->state != XenbusStateConnected)
>+              return;
>+      err = xenbus_printf(XBT_NIL, dev->nodename, "state", "%d", dev->state);
>+      if (err) {
>+              pr_fmt("Error writing the state");

What's this? pr_fmt() alone makes no sense at all, and I'd be
pretty surprised if the compiler didn't warn about this construct.

Further, you probably want to say "re-writing" and include the
error code in the message. And of course you want a \n at the

Finally - no need for the braces ...

>+      }
>+      return;

... nor this "return".


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.