[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: always consider '/' as a division in assembly
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 10 Feb 2026 16:19:22 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MuES9yc2kGEuLr8wj2cvtaI/4i6YVtbc9iDdEMJS0u0=; b=VHEga9XzI37sEsooTOzg4VRtDt7Ycp9xdyLI32rYS624wR70cUpgrXHEu74ToJTW9fy2EhMnM59tRkFKKvELIEsYMs5wubjpoSYmop6C1S5FBuWzQBIBC4z4UyW/nckFQQS8J+BBGqsKez38+Jp/6EIEiwMeCBMFhqEy+kqL+3jkRyFlSyvYxIz8wI42QB3NF13VHD9Z2t7XQ1ybeOBUsXl5mnnB15v8moAyaynfT8t2n6YVGXvaJpz5NlQGmJvCfTfvXVVudLTgP3f0xHdjmSJsLCztkdJyK38E0raMmdxyJ7scoUS5lRhcWZm8ucdcKBocjYbziQOIZFvhyXmVOQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MuES9yc2kGEuLr8wj2cvtaI/4i6YVtbc9iDdEMJS0u0=; b=Il8BkqtqCihbm4+71G+GR4Rujb0wGUc5CyfvbEvp0X+1fsnYXBxx5pDSm+lTT1+kSwQvRcaaudccmQLdOOzCXa3KGyfLK3R3SZHcfgLkGvFIE3gAppGby9zOrDK5g3X9EVbaBbli8MRNJCXVbh0li7/7ad8+nC8EQmVbV62ttexOQTYJmV/4wF5jm+48smwK+CHO/rJaD9vvHaB4eMNRL/lz1jdjgllCJXFb1c6umgMMtxXI+CVtXtZoXwbAvjOr2UJjSbF2lyRmjb9r1LmioXd76VJN7t+bviU+g2XmeJ+xg9WWtB5rCbekEQlLL/yJLYNvmmsNJC/5Acd/7Ckxdg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=D6MiqnvQfmJGpWM6vXUf8OLaTbe3GNA/RKwIcakRU026BudyqCqh8x/ucqA+D7d6vRQBHBWgcsHfcBiDqBWDNQQGQZH9yVFqssfIxUfDs+a+aTXIkqgp9E54/xqHJ29UGh0NWF0u2pzYW4Tb/jj6fTTqQk8nHA33F3SqPmhEWvSG3wbE1XwuNOIw732W4L6MPzThrkN4zhjY2sKbTpAMxBmhwMShIkprq7loft4gSWS3LDBLo9AjudWvzwZGOcpjsfywnbJaj99iH75JcwkGM3UTq0AGYckMsf5S4HVxsOafi1CoJFeFaCa+If0IgGUVXd58MGRUouGbuzpB42ysrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=egINlBbaBtTGoYvnMtR889JOLWj4cnMFDNyzAvFahXsGJmAMQwkEEIGEJrdi+2Y2SzCArTjXrAa22GL6L+/i3gumDmKC+WrhPGqx8L1pWsRXqDwvxjy1czs/VpuabMRuDqX7cR6R2N2A1ktRT9tI8RIzvTRR+5jVLv+ZhI1ZSggHDFnB1tNqGCVpajsxbv0ZjO4CrBCRS2ASEldIomD+n6h94yxRr5UUSs1ULmsLoc5TYZNWCaUfbGQz7+ihHQic+hPdnkp5wSdygm1ra1eSoi2h1nHzZD03AObER52JZ5ihl5jF0UpknmxmTCGIZAMPotfsSfhT/zu+XOgcNMFuRA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 10 Feb 2026 16:20:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcmp+J15vvFrxtUEGxE7lRiZXN1rV8EwEAgAADNACAAABcgIAAA2IAgAABnQCAAAEsAA==
- Thread-topic: [PATCH] xen: always consider '/' as a division in assembly
Hi,
> On 10 Feb 2026, at 17:15, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 10.02.2026 17:09, Roger Pau Monné wrote:
>> On Tue, Feb 10, 2026 at 03:57:17PM +0000, Bertrand Marquis wrote:
>>> Hi Roger
>>>
>>>> On 10 Feb 2026, at 16:55, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>>>>
>>>> On Tue, Feb 10, 2026 at 03:44:33PM +0000, Bertrand Marquis wrote:
>>>>> Hi Roger,
>>>>>
>>>>>> On 10 Feb 2026, at 16:11, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>>>>>>
>>>>>> GNU assembler will consider '/' as the start of comment marker on some
>>>>>> platforms. This is incorrect with Xen's usage, which does use '/' in
>>>>>> assembly files as a mathematical operator.
>>>>>>
>>>>>> The behavior of the assembler can be altered by passing the --divide
>>>>>> option; unconditionally pass this option when available to force the
>>>>>> expected behavior.
>>>>>
>>>>> This is solving the issue and I can build for arm with what and further
>>>>> for x86 on mac os but it fails on check-endbr.sh:
>>>>>
>>>>> /bin/sh ../tools/check-endbr.sh xen-syms
>>>>> stat: illegal option -- c
>>>>
>>>> Yeah, I know. I've fixed the stat issue, but there's a further one
>>>> about an illegal bit sequence in grep. I'm looking into that.
>>>
>>> LC_ALL=C grep is fixing that one on my side
>>
>> I haven't tested that one yet, but yes, might be a way to solve.
>> Would you like to send the fix for grep?
>>
>>> with that and stat -c replaced with wc -c < xx I can fully compile x86 on
>>> Mac os.
>>
>> Yeah, the problem with using wc is that you have to read the file. I
>> prefer $(($(du <file> |cut -w -f1) << 9)) because that avoids reading
>> the actual data to count.
>
> But shifting by hardcoded 9 doesn't look very portable. The size not being
> exact may be okay for the purposes here, but wouldn't it then be better to
> use (standardized) ls output?
Suggesting this:
wc -c < "$TEXT_BIN"
Bertrand
|
