[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: always consider '/' as a division in assembly
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 10 Feb 2026 17:09:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wK31RsiUalQL7N9i71GiWC+3ugjqa5KY0q4sc7C5D7k=; b=T245PhiwpdfI9hU16jvXusxSsOPqOidbCk2CUJznyUdCajr7JPA5zTEv7Tt468T8VQIuAawLGwU8mMIqgWQ8uFp7XUnn4mk41rnNQ3as084OtIOMBjV3kywiPdEAehRJtCK6FkiGIjYcukKxeHI0VVga4zhjSLYklWgumTXGW4h70ZbT3J4CQa/izzY+gyo2vfkeXtMjGIeo4ocTPMlKGjNyltUZdrC7FWsbc62r/ggXB0YAGapfUCuNmexqa0nNTmN3+7FV1tkaEnzj6fB033DfQ7CoWy1GkzfRBYBTjh3xSo6GeHxPP2fHMPFK+w9gQHWaBcxmd6E66lB3EnxNpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TLrlqcmReKoP/ApAOW5Bhctqh7RuGXZ7V5HxFMxNkS2pnqSLJTyBxPNQJzA3qEO4e/8rDaTC/T/QVx0NJG99WzREMIoW/jAAZtSqUIKS+dKxF3mZJtjqc4FNwJVrMjaQqv4tOcrwY4l8eLvkTRENUHd/S6+8+94VcNE/5qqnTJL9GTZdoU4Bw2xHR4XUVG25NaAEB/HiRDgq97M7DPtrCdvhNHuSoqqGWHN9UMpFS19pKnbLww02gtZX9zPO88U1Ragf04D1KQsGhFdYlhnIBRdF35KMzGQFSD5hUkZ5e3Tgqh0Iia7u3rtAc47nTkRPYS4tKCTuxdAnEkTrL5Q3aQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 10 Feb 2026 16:09:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Feb 10, 2026 at 03:57:17PM +0000, Bertrand Marquis wrote:
> Hi Roger
>
> > On 10 Feb 2026, at 16:55, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
> >
> > On Tue, Feb 10, 2026 at 03:44:33PM +0000, Bertrand Marquis wrote:
> >> Hi Roger,
> >>
> >>> On 10 Feb 2026, at 16:11, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> >>>
> >>> GNU assembler will consider '/' as the start of comment marker on some
> >>> platforms. This is incorrect with Xen's usage, which does use '/' in
> >>> assembly files as a mathematical operator.
> >>>
> >>> The behavior of the assembler can be altered by passing the --divide
> >>> option; unconditionally pass this option when available to force the
> >>> expected behavior.
> >>
> >> This is solving the issue and I can build for arm with what and further
> >> for x86 on mac os but it fails on check-endbr.sh:
> >>
> >> /bin/sh ../tools/check-endbr.sh xen-syms
> >> stat: illegal option -- c
> >
> > Yeah, I know. I've fixed the stat issue, but there's a further one
> > about an illegal bit sequence in grep. I'm looking into that.
>
> LC_ALL=C grep is fixing that one on my side
I haven't tested that one yet, but yes, might be a way to solve.
Would you like to send the fix for grep?
> with that and stat -c replaced with wc -c < xx I can fully compile x86 on Mac
> os.
Yeah, the problem with using wc is that you have to read the file. I
prefer $(($(du <file> |cut -w -f1) << 9)) because that avoids reading
the actual data to count.
Thanks, Roger.
|
