[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: always consider '/' as a division in assembly
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 10 Feb 2026 17:15:00 +0100
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 10 Feb 2026 16:15:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.02.2026 17:09, Roger Pau Monné wrote:
> On Tue, Feb 10, 2026 at 03:57:17PM +0000, Bertrand Marquis wrote:
>> Hi Roger
>>
>>> On 10 Feb 2026, at 16:55, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>>>
>>> On Tue, Feb 10, 2026 at 03:44:33PM +0000, Bertrand Marquis wrote:
>>>> Hi Roger,
>>>>
>>>>> On 10 Feb 2026, at 16:11, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>>>>>
>>>>> GNU assembler will consider '/' as the start of comment marker on some
>>>>> platforms. This is incorrect with Xen's usage, which does use '/' in
>>>>> assembly files as a mathematical operator.
>>>>>
>>>>> The behavior of the assembler can be altered by passing the --divide
>>>>> option; unconditionally pass this option when available to force the
>>>>> expected behavior.
>>>>
>>>> This is solving the issue and I can build for arm with what and further
>>>> for x86 on mac os but it fails on check-endbr.sh:
>>>>
>>>> /bin/sh ../tools/check-endbr.sh xen-syms
>>>> stat: illegal option -- c
>>>
>>> Yeah, I know. I've fixed the stat issue, but there's a further one
>>> about an illegal bit sequence in grep. I'm looking into that.
>>
>> LC_ALL=C grep is fixing that one on my side
>
> I haven't tested that one yet, but yes, might be a way to solve.
> Would you like to send the fix for grep?
>
>> with that and stat -c replaced with wc -c < xx I can fully compile x86 on
>> Mac os.
>
> Yeah, the problem with using wc is that you have to read the file. I
> prefer $(($(du <file> |cut -w -f1) << 9)) because that avoids reading
> the actual data to count.
But shifting by hardcoded 9 doesn't look very portable. The size not being
exact may be okay for the purposes here, but wouldn't it then be better to
use (standardized) ls output?
Jan
|
