[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: always consider '/' as a division in assembly
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 10 Feb 2026 15:44:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=citrix.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vF6m0x9VN7V7vBQiJYweyuyAMDhdyN/JKcy16z90xZc=; b=UYA6418pvdnYtf9rvo8yWM8L3/hn4ifi/0aVpdza4uNe7lVahShKbqQP9KU2f3NuGBD1SXBz8JUGlTE33+aNQK1jPAnARzsDeUMeuxVNdL2AZbLEmKFqqglzJeBpX4oGyH5EOL9adfx7wjWJNQEZcKjWcf8XRKGMlthRFDEwggKvuqQ4vLDX2fHWxpmSml0l0H+62jVNbXF57SfhHFUqksgWjyU073wXKCQX9c6mf6AgL+suMboQo33e+9ELxtZzz3aIoERXD9O2Ls7EgtzCeZhyGPZzvGAFErx9fcDhNorVOCZWNi6aWxc+3U59Bx9V3japjrWorgWwrSC5hcdFGw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vF6m0x9VN7V7vBQiJYweyuyAMDhdyN/JKcy16z90xZc=; b=A4+6UmlxWd6OUZaBzaMyxQVr41Y2N0e2AhkVU4W6T+y/8a0HaHubmHzqKLo+ryJu8dNOW9cyHBpINh7abTtgInp3lKS4On0+O8hzxxxfPT3ga9ca+P0RcGsMUveF29oMKPfy7YnJPC+M+zEC0gmvph+ENF2zX7zrg9/THcK13RyEukLSJCe3EOY7xOEt1onOAaHTLc+JB86rB35FelHN41UuYTzDr1Dxkpsz+bixPLTKi5zbQ31kV+pZrB9TzecwHvllYID30U5+CPzWbc5aAQzjNnbnuNICNMZPlJx+DQkZZhyLMd36vi2uOpzIIhN+JxTAodmmMNjbp2K31lj5eg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=NNPI3rVkbYTLdDkdQ2AFX20M8gmbFgwJB2HXWkci/UFPAX98asT4iX+NwnfqPM6Jl5K5sShmjJ6QhOZeojgtHuE9j862L12t6L2HIV7B/RSnvXRoIV1dLGz6Xak2KhqM30aFIBgBOInxTIzHjEy0wngrkg1mpXU95A92PYbBALOil0OfVG6/33u967KqmKNbDOYSF+iDRU8yLmYjf6q1fLLgus79Hrl4m3v/1sCVKm0MLiVD41NBMbK21LwFnxygALG9XwCkPw7M4EZ01bAqDdVa55dAl0VgqIeynBHXPrCgE33PQiwUdF1ppCdVPzo1Td28hKR52u4Oro/JhtDYNg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s0xHF6XjXMjy1CavU5KnYNoxKq6IOQXhiJd04rTxYYOjh5hQT0B/cC0KyKWXVQSoUgKMqZgWQBv6QtHL6pRQAnsVq2Ydrj+QoaQ8+7RJYBCQ9nEptLJd8vxIN5AgXzx9cQQAkweGBaZZz+uyrAqBN/mSglP5fD+sJD5tmVr49lkC0ArBkGMov6fac1wDqZ9kUm94FA8KGQiyJ5xFDTrS+1P23uN0m9YoCcYQdmpwW63sqAyxX6rSdRIHisw7RfGZBAzfJjB6P6Xo9hmb5Qg1N08iJpi/4b3WNlWvnQRsAp+6H5jJJ0XqbnevgJchKiTGqVlPgRrjcOfaDlihGiLywQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 10 Feb 2026 15:45:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcmp+J15vvFrxtUEGxE7lRiZXN1rV8EwEA
- Thread-topic: [PATCH] xen: always consider '/' as a division in assembly
Hi Roger,
> On 10 Feb 2026, at 16:11, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>
> GNU assembler will consider '/' as the start of comment marker on some
> platforms. This is incorrect with Xen's usage, which does use '/' in
> assembly files as a mathematical operator.
>
> The behavior of the assembler can be altered by passing the --divide
> option; unconditionally pass this option when available to force the
> expected behavior.
This is solving the issue and I can build for arm with what and further
for x86 on mac os but it fails on check-endbr.sh:
/bin/sh ../tools/check-endbr.sh xen-syms
stat: illegal option -- c
Cheers
Bertrand
>
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> xen/Makefile | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/xen/Makefile b/xen/Makefile
> index 31352d4cd260..eee0262933a7 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -405,6 +405,11 @@ $(call cc-option-add,CFLAGS,CC,-Winit-self)
> CFLAGS += -pipe -D__XEN__ -include $(srctree)/include/xen/config.h
> CFLAGS-$(CONFIG_DEBUG_INFO) += -g
>
> +# The GNU assembler will interpret '/' as a comment start marker instead of a
> +# divide on some platforms. Pass --divide when when available to signal '/'
> is
> +# always used as an operator in assembly.
> +$(call cc-option-add,CFLAGS,CC,-Wa$$(comma)--divide)
> +
> ifneq ($(CONFIG_CC_IS_CLANG),y)
> # Clang doesn't understand this command line argument, and doesn't appear to
> # have a suitable alternative. The resulting compiled binary does function,
> --
> 2.51.0
>
|
