[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: always consider '/' as a division in assembly
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 10 Feb 2026 16:20:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=citrix.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMdoimyC4nMbT+zUkxxxLe5Fsxq9SjQQ8ubcb2Hmxsk=; b=VRBoea16/JB9rIj6fpi6c9/oTu1oMLtXyG/FnuylmZFyQ/QE47fWoUvllwwq35rwuGepaPxSj8+TC+V2PZv3xWasAD3rVyp88Rp79c4LXuCNwYgKLNUq6jb9AisXyW+M86e8WcXiXDOpuhtirTfPN756RaWk76+g7OnBxTmHxinsxvsXCXnsFtcYPb5m3fnhjYu4hS77ckR9qtXimfhVZmx4kh8w9/8YqicHFRj9HUPG2YgU3RVd7QbkYfXsT01veRuOc+6ZFeWNc6BcOVTwIIlzJ0X83fbSfq4AZrhmQV2a4m+VAEZt8XZFwProwUpsdbzc3K+49uqQJ8H3M8J2Pw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMdoimyC4nMbT+zUkxxxLe5Fsxq9SjQQ8ubcb2Hmxsk=; b=kXZXvvWGuUqC4qOmuUokXrcD54yY6LNSPDTUNAeVqy7Rr04uuJYnP0Rs41vG9t22KuOAS3T0x53dW2bh2bqcF3iRBEH5xdwn1RV52ZJCORE6SqfR0C6M9EOHm+inVv645Nmmpo8bqfL30UWK44ygAPkmZ0AQjDlq2AwvYemyJRsH5KQHwWj/Xd0OsRD6SDWvPNGiArejx1lCwAxp8DjA+I2Mv78GF+Z7LcxpNkos01NvDyVCJsi6IYX4p4GvrDqcS2SCGDH6bFMLLIveyWREgR2+YwNYbh+ex4Wc1Cu7K4J0TnYtUJwCBdlFIJgMAKMSMf+2Eu/TQj9yWab1ghVj4g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=y0WLSR6trpH6mQj+hYCCYmfTyIZi5eOdmT65qzpiXVstDriuqH6Mo83tqWatUFGEQMDcahdV2TOgLXjIxx18kXvlSv8BEmuqcM/SuOgl8bxPuEtORnTWKmQnQhc3QIzhHyswzrbIOXnvcg5nRLTVAdB3o8NpNnO5kHrRxAI9AVvN3YhpjiHtIbuTPTpaMaF0kNMPmjXiR+wRt6oApYVjcjCtXiYydx+zIuXCb4hYQCw8bsdBIS1X7ZQgSqyDXSkxZm27k0iOpbxx/1VpT/Kn73bCZUiE8+5xJNf35XYCzPtU/Jvqz/Blcom91jm9VGv6fNZZA9xkWXvhQoUidrEODg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OIiMSrMl+3UqEHZ8Y2YL/N4i/AWeiS8rAUUwqXyNo7EJdioPOwDA3m1L3FOZNuaiIKl/fcUo1apBL68nCbzIc0QxyL2dKBYmIt8mLTinXK0wqu1AiVXUtl92PiXECRl8b9cPTgL/+Kw4dYsHVXiqVyYr7V6ztzWVM+p3VjEY1Vs8DXzvkGqzQQV77imV///8aEFQbDH1NZCCX/IwuvUiZHIemRnEF5Y8E64WfBiQPhdqhTOQS3owcAwC34O6HuK54H/vbHD7HJA2Jrm43DVqTL4WIYs+dUMzq3hwFw2W8KZbWg8cEJde5FEqhEJvniNJ7wz0aJIAJZ0AcryBaAiKig==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 10 Feb 2026 16:21:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcmp+J15vvFrxtUEGxE7lRiZXN1rV8EwEAgAADNACAAABcgIAAA2IAgAADHQA=
- Thread-topic: [PATCH] xen: always consider '/' as a division in assembly
Hi Roger,
> On 10 Feb 2026, at 17:09, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>
> On Tue, Feb 10, 2026 at 03:57:17PM +0000, Bertrand Marquis wrote:
>> Hi Roger
>>
>>> On 10 Feb 2026, at 16:55, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>>>
>>> On Tue, Feb 10, 2026 at 03:44:33PM +0000, Bertrand Marquis wrote:
>>>> Hi Roger,
>>>>
>>>>> On 10 Feb 2026, at 16:11, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>>>>>
>>>>> GNU assembler will consider '/' as the start of comment marker on some
>>>>> platforms. This is incorrect with Xen's usage, which does use '/' in
>>>>> assembly files as a mathematical operator.
>>>>>
>>>>> The behavior of the assembler can be altered by passing the --divide
>>>>> option; unconditionally pass this option when available to force the
>>>>> expected behavior.
>>>>
>>>> This is solving the issue and I can build for arm with what and further
>>>> for x86 on mac os but it fails on check-endbr.sh:
>>>>
>>>> /bin/sh ../tools/check-endbr.sh xen-syms
>>>> stat: illegal option -- c
>>>
>>> Yeah, I know. I've fixed the stat issue, but there's a further one
>>> about an illegal bit sequence in grep. I'm looking into that.
>>
>> LC_ALL=C grep is fixing that one on my side
>
> I haven't tested that one yet, but yes, might be a way to solve.
> Would you like to send the fix for grep?
>
>> with that and stat -c replaced with wc -c < xx I can fully compile x86 on
>> Mac os.
>
> Yeah, the problem with using wc is that you have to read the file. I
> prefer $(($(du <file> |cut -w -f1) << 9)) because that avoids reading
> the actual data to count.
Both fixes should be included in the same patch.
Will submit one once we agree on the solution for stat -c.
I suggested:
wc -c < "$TEXT_BIN"
Tell me if that works for you.
Cheers
Bertrand
>
> Thanks, Roger.
|
