[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 3/7] x86: add deviation comments for asm-only functions


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 19 Oct 2023 08:55:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/bhVrLuQPKC+8kpciL3ONqdJ4d3A2oDVyZxZYwtoTOY=; b=lWV8vXE9vCcmjN5f9Jl53eTc7WrGG/Ui2q7GjqqeqWCuqs50pqUJ9WeR+ppzTIZCPgmNQ45tU804DoG7pOVra1pMen5goSErP+2w2LLw3/F3PFj5g/uF7u1OQUQvveC/CW1m1GVxfzxu4ik3dv4fUq5FyavsHOb/KcXA6GOgUDEvHUlRPvRHJ3r/4zs9Ta8psIBgb3ZcsZ+kNCF7Et4zUZDN98YoxT0s1rZOF3jLVaNA1xhFOxFvmf/rscDKjbHCMz2xOsXUkPVv/FWyLwr+ue8GjuC3HtdE/7coHTOWpirUFuaQKf49MUryq5KlUrYfIhVI+2EB4686jMBd1ADAvw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJwmPOSaH4dk712KIwHdjh10cWBXMid30YyOKCtYLtzvSkHm0mF88ZBKlEpc2JFrce6hDVlXC0nGdyR/9GdW32uXQsxJ0f2onsi8tXbcioUvzt802BICJONr1WLVjPz+BITQarLqqaXCfjxyK+REmoJ1pc+MeGWLfcYRJKDqgmQ3Trj+MOcSBtJMAlaFxY44ZudVmv69Dw9X5sYpdBn9a1eenkv8OnuNselYbGaCUHCZsxnjIRiyaqmIYAIBG0Q0JDyVDxlK9MYEExeFTjCJc2g3Ei5SucnWsLJdS2Em1L/5s6gePcVpySJXJu2KMypFwBqW1eJDGEfLxbre7ptdsg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 19 Oct 2023 06:55:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.10.2023 02:07, Stefano Stabellini wrote:
> On Tue, 17 Oct 2023, Jan Beulich wrote:
>>> Jan, for this specific patch, I don't think we have the scan including
>>> Intel vmx files yet. Nicola please correct me if I am wrong. So Nicola
>>> wouldn't be able to easily expand this patch to also cover Intel vmx
>>> violations of this rule because we don't have the list of violations
>>> affecting those files. 
>>
>> I'm afraid I disagree: There are likely direct VMX counterparts to the SVM
>> items adjusted. No scan is needed to spot those. Anything VMX-only can be
>> left separate, sure.
> 
> Nicola is new to the codebase, so let us help.
> 
> This patch adds deviations for these SVM functions:
> - svm_intr_assist
> - nsvm_vcpu_switch
> - svm_vmenter_helper
> - svm_vmexit_handler
> 
> I take these are the VMX equivalents:
> - vmx_intr_assist
> - nvmx_switch_guest
> - vmx_vmenter_helper
> - vmx_asm_vmexit_handler
> 
> Jan, did I miss anything?

At the first glance - no, I don't think you do.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.