[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 3/7] x86: add deviation comments for asm-only functions
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Oct 2023 17:00:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tg9/GFYyGyUVGOQjMU63LgqXeYDpBC2GMuNdmMdhzZg=; b=cmBqqOaTGEwBZ6bRCvi6EP+opPpiQUda8cMWGaIkLMHoW7WE8IPsPjF/WbqwEJjDiu6Do4B9dAY8VIN0W3lFPF0zt7LuG0w2Z9YAep2v4KK9U4+cj4OhN4PGy0XEuLh6BxS7pVw23g6Emiq23knUahf0zIHsXMApoo21zjnd1SuRWs4hosmRI8XLJCXSG7EQ5wb8R2ZqkHUntPUbZyu4w+1HhqLuuuHaX+d1LaDPX15GG8S6YXKdNyt7tIFqDdnmiBdRhli9whQXgMWSWej2BStthfOCj38MzIOWRtdqE/MNKqF98kGOOCBPKHfnEwIRfADtC7I3OyYDqnCyKKqdsg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hxz5dPWM3mm/vlQlUKWo7YskWR6o4PN58mrlakFeQu9E9QUKyxQGke4By5h192uLpnR2QWXGEA32N43EVr8KJHyopndst/o6CEfFCIQzlmH6L19bFzoqhPapeq/y01JviYrwh/cuoSO0+GaqEx6f7HBy8Zppdn9fT3frV+AdCf37Kb0AuhxmUFADk9wDQkcDmh8kmvR04ZN5qp/AXgQSj+4goXOV4krLpiPvytLRvceJ0pmgXRX9yHlpBtLfUoabjAlUDMFbmR9pmO4oKUv0B2wF7dPAPgYhz0jiz5aUaw6ZiuE0bEcdhK9H/7QxJC7zLQhPtlxxqvIm6+vjMkkV8w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 16 Oct 2023 15:00:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.10.2023 08:54, Nicola Vetrini wrote:
> As stated in rules.rst, functions used only in asm code
> are allowed to have no prior declaration visible when being
> defined, hence these functions are deviated.
> This also fixes violations of MISRA C:2012 Rule 8.4.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
> xen/arch/x86/hvm/svm/intr.c | 1 +
> xen/arch/x86/hvm/svm/nestedsvm.c | 1 +
> xen/arch/x86/hvm/svm/svm.c | 2 ++
Once again - why are you not also adjusting the respective VMX code?
Iirc it was agreed long ago that scans should be extended to cover as
much of the code base as possible.
Jan
|
