[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 2/7] x86: add deviations for variables only used in asm code
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Oct 2023 16:58:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6eM7keAu2fc1cCD9Ixxhsz+zh3NWnS7hgkywVO2kXss=; b=SEeb0iyAf9ySlvg+XV2503jnNczKpCawf5zU5iDzI0uVosxn3W6UVlh+Ao0wSWV/9dNrqivPqGS4uPm/QXYPh1y0redNPP70c9n/1kCrrVJyALdSlWOVNC4X6xyPibBx6SbpH0LCMpDRCyrWle5rQNFUhxbhyzL+q+M9Aoa6PEePvCNoUODg2OlxKig6dLd4MwSBCcSfzfdAgTatpo6fKl53oA+FmIBWVCQ9DHJDLjvnWieiZIN7VLoJdrcIdNKlCUKwsL5rDHnN5Mjb5elVP0PCUdaNIYEXB0//mRBnl23BbLYPT6pdwNfH+/xNxUEc8uZjhDMin02pKsjzfMouow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gv1dMZh8OAGthC/Hjaw3NXO3bxaeGV/aoVU2cIpS1pmyvLZ14ndGUK43wdh+OvGacxOPoA0bvgZG3ZAknbdPLuZiYz4uppCVCb4roNKMOYGa1w0+bRbRlpD6E01+19gf6jXIBDfipdDhPaO4jCI+RDx4eSK4DoESwF9MDGo7dCcuipObhFfhhFmakBFz/IfRxi8b3sp9JvmluzLH6NcVfn5c8UVooIlPVtVp5kZ6DQRYFEwZb59NHwZvHi3irsEgUtc8KzGx5uB7v80OWA9D4+l66p8D/kCu3gjSJQ/DxeZ0vflTQw0xH71gjGqWoUYq9+xLKXp1mamjiug/dOWjwA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 16 Oct 2023 14:58:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.10.2023 08:54, Nicola Vetrini wrote:
> These variables are only used by asm code, and therefore
> the lack of a declaration is justified by the corresponding
> deviation comment.
Hmm, you say "declaration" here, but according to my understanding ...
> --- a/xen/arch/x86/include/asm/asm_defns.h
> +++ b/xen/arch/x86/include/asm/asm_defns.h
> @@ -31,6 +31,7 @@ asm ( "\t.equ CONFIG_INDIRECT_THUNK, "
> * gets set up by the containing function.
> */
> #ifdef CONFIG_FRAME_POINTER
> +/* SAF-1-safe */
> register unsigned long current_stack_pointer asm("rsp");
... this is a declaration, not a definition.
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -153,6 +153,7 @@ char __section(".init.bss.stack_aligned")
> __aligned(STACK_SIZE)
> void *stack_start = cpu0_stack + STACK_SIZE - sizeof(struct cpu_info);
>
> /* Used by the boot asm to stash the relocated multiboot info pointer. */
> +/* SAF-1-safe */
> unsigned int __initdata multiboot_ptr;
Imo such comments want folding; question is whether the tooling can
cope.
Jan
|
