[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 26 Sep 2022 09:38:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+sPYd1N0tcc6nXClerFhbPKDko76+vUqNtqyBEH4eU=; b=A5xreRt9WYCrRhca0ztN42GvJBAIJzUCWuadzyFcE6AL8wiklPIU3X4rAX78Cstse9jDL+Rjcr+bQgNL6mwKHVnfGAY6z6jzwae1hyPDG399Svzpo/82T0kP+VMAHbe75e4IlzcB/bVmqkdNy1CIVT59J4y4ovsNZ8cqZ4KzNWMO/75wXZ5niuGldXE5qO8n0jlXEbh5IHE6m6wE7E4Z6F91Kva9rsCPanwDyNT/4BBuaR536n22GIQd2bXqLyb+TMpxp6GmYNxVlSm15ffxeTofJgjtCFjjGi5lTPg/PzBCZvPmVB2hDjBQR2fQT1lJukb9kxcSztuT2Onoynxsmw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mb4DuymP5xSxAyNZouH16gzyZKhvFmTf15jYnuEhQd2IRQs5Ub+l85DVgqSw2IGRaoLJch56tp+33XK2uwv83UgQS/iPl9TGR97JxoLCNzDxxY29v2VIKF9LrfyIfmtmGYietXjuZRz/1E5HbTOdrQDFyThlcqS+8rgRy2IrIdUQGer5L7kp1DjAocXkJcQVQi74o0yo62ZSZjjzX/LoegMRbIV9ELDpc+rEkU3p8gJaiiDaATTKoNTnJXkJK5MxwhMNxXqZNL6OooP2WNcuZLQx8sRb2H5sYIBpHuUauVYXq+mj96B4kfT4mVwOKyGhQz0OKKN8yQc3iNV/pq0qIg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 26 Sep 2022 07:38:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.09.2022 14:10, Ayan Kumar Halder wrote:
> On 23/09/2022 12:02, Rahul Singh wrote:
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
>> printk(XENLOG_INFO "Xen dom0less mode detected\n");
>>
>> if ( acpi_disabled )
>> + {
>> create_domUs();
>> -
>> - alloc_static_evtchn();
>> + alloc_static_evtchn();
>
> Can the code in alloc_static_evtchn() be guarded with "#ifndef
> CONFIG_ACPI ... endif" ?
This wouldn't help the issue, but at best code size when !CONFIG_ACPI. When
CONFIG_ACPI=y, acpi_disabled might still be true, and hence the function
may still need skipping. Apart from this I'd also consider it odd to have
a non-ACPI function have such an #ifdef ...
Jan
|
