[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
- To: Rahul Singh <rahul.singh@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Fri, 23 Sep 2022 13:10:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FzURtjbh1BMXeIbIvlhHYOSGR+CZp5qngLInO6UfwOc=; b=cGBidgL2qVsYaXnTQC3v5wur2oMztwjNiffJ8Z6qH3DkjSJZEtxleCJ5uVEdU06iC3RYkiCbCQ/tZZhFzoFvhazutXcx6/GfDRJj3dRTc3DIFC0V1i+bpDwHjX+dzIT4jLKHxOG6fMqdeWUAghP5NNnprhncrqap6DAYi6St2znDds+UPWqHzQJPNGDeVRVn1xAPehMPKNUCFz7DKAXzavwNrcWq7i6UNQZOKKp2AMlkD4N4eOd0eAa8Lg+Wry7puKyj+/zzQ3IjyYEjeiinE88uZnQltbhi0woyRZcpzLJjetvqJFpBYriDu3ZAMd3jqLW9Enm4CtRk+21f898D8g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egwba4Y8M7d9MLa73h+44+AfeOdzwzhTL5OC+JeZt1WKTkzaWk+64S5jDTgYt+tFkuEt+AFtnGIkCqbjAfRWX4gKfpwuaKcf5kwAsj23UXC4j4rMkcvclWthmdyZPOB1gWazmQ/5sIqR4dpFxNoL2HuwgnxttS7HwZhctbi37ZHWSVsw/0vhZXAu9YqgdSJnGQ6uijgpDrjibg2ujTg0Xyj1jgWgraBjSHTlpbRmV3x1iXuxCY5FOP2Kn1dx5cjryjb9aAbg2w0pBAW+9nfxapNC+pnbgHlSaOWv2bIWrAo9+KdR9wTIrzzj2Opqa+eQkP44pACyyd0dffJPzWu+/w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 23 Sep 2022 12:10:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Rahul,
On 23/09/2022 12:02, Rahul Singh wrote:
CAUTION: This message has originated from an External Source. Please use proper
judgment and caution when opening attachments, clicking links, or responding to
this email.
When ACPI is enabled and the system booted with ACPI, BUG() is observed
after merging the static event channel series. As there is not DT when
[NIT] : s/not/no
booted with ACPI there will be no chosen node because of that
"BUG_ON(chosen == NULL)" will be hit.
(XEN) Xen BUG at arch/arm/domain_build.c:3578
Is the bug seen on the gitlab ci ?
Move call to alloc_static_evtchn() under acpi_disabled check to fix the
issue.
Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property)
Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
---
xen/arch/arm/setup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 61b4f258a0..4395640019 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
printk(XENLOG_INFO "Xen dom0less mode detected\n");
if ( acpi_disabled )
+ {
create_domUs();
-
- alloc_static_evtchn();
+ alloc_static_evtchn();
Can the code in alloc_static_evtchn() be guarded with "#ifndef
CONFIG_ACPI ... endif" ?
- Ayan
+ }
/*
* This needs to be called **before** heap_init_late() so modules
--
2.25.1
|
