[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Fri, 23 Sep 2022 15:42:52 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+jU8+ToR2i5jp0usVgH7Lokh2KuQEXfN0JTZgDdlRU=; b=PFUHkzPo3hUpoFXheliJnV/gEq0TZoNbIRRn168ctCtFX9dRblbdpG3WFMZOAquA/iFe2RjEwbq6PNyQf8Ok9iEGW7zD9hp+GbaHkY+4fK+Trq6IVdUDbY6Vz2hSFWEv8MW1Wk1kzfcD06+lP0/yvNinhkxySxCiQdIHbkzLiqsqDVOF+6Pi9OrMiXPuIbp5vRT2xwJW4UvXbu359QgdA/x5xPfhfaIGMC4A0zwGGPbCA1Pxh3bFDG0KguaHJ5k7lyp6y9zlzwYOsBoINbAIT+goMF/7TJLKZdbPR2nTI4Y6XCtPq4fPm0Q9QcD4qCzt2dEoYQN4Cl5JRWiUO1cyLA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+jU8+ToR2i5jp0usVgH7Lokh2KuQEXfN0JTZgDdlRU=; b=RY7yc8Ky0XVui+NzUR2+91q+kzzp9yppyQMNiexDw7XiQw0VeG3/BEjN4ZWmegKoaguKVaErczS+BJ4n6gbCDA3hw1GvVEP6ooJpQSnDkeYRGciMh3ppE8hmnnzW7j7VRaROZYlN1hW/f1dY3RH6u4NaStRRtyHDoMrrszB0MUQmqki+jhK5J1RHUWLKBRk7JgNLuFLhcqA6ggznoUlFYh4ilC/mqgt+Clu3z/9OZOkkV7CqqQA55xyXfG6KwHGayuYH65i/ZVnC0DZxwp0J4h8xdtLRrNwSkLkqmLO/tDpvgdfdQfHXilwHh+1YYHuGA0TgqFwtSIodMX5Fx7O1zA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jePM00MneEfZ5IM7n/OjIO0xyig9bx+chJG8G3S+jlhvV3vyPP5RCAowrqQqNE4o5yeiG6GKwzchp5JiZcgArbasbNRPkAlKPO74yqEquNwGdapc3PKJT2TcZsE6coV/DQDE1KAeDI0IadUPgfGY8sM/9osG60UJHLchkB6f1a8t9aKm883CJN9RykeTFY9fV0NIhfgA2s05ugBlsDV79AMcGGhxd/cDUzgAohqW4dNXYIl5GwKZKxDDzibYNhWjGYaAnQCcDC/09NTkxh8RV3SVNnE2EoxoqLSeF75l0HFlR2kkd4pfeg2g/zJrIcyBUEq+JMnynjbDsGyGSqCetA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjDkYCysTXhL61HkBkdxE7BJ6oF6/XW4SWgoNtXQ5kzqhu+OEfLP6xNfIMsyVhwM/7ePdQSsmFPkY7b6TimItznzBNeYBKaTKPrAFgeki+uMGZGijnb/4Nf4Q6XJ9/6dlA6QC1g5Xk/dYUMBfrQyIZ9lP1SKV63lDMWV+mG+7fiuF4p1Rd5pPgLAAPZLFTUoueDShhTApVnLSE4zNmCb4Ny8KK2u3UiY06pmG/2+u3uL4LBh1U8rxXWDq4pDp6+0qaudsOcxnlrG9IIOTzxsXZrateCOHqvySc8dUHpPlmzuIGY7yEHHtvGMyk2tTipbda6rHv0NCFqp4xaPJitkvg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 23 Sep 2022 15:43:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYzzwtnQ0btLDO4Eq57Exdd2Iqca3s7GqAgAA7ZIA=
- Thread-topic: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
Hi Ayan,
> On 23 Sep 2022, at 1:10 pm, Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
>
> Hi Rahul,
>
> On 23/09/2022 12:02, Rahul Singh wrote:
>> CAUTION: This message has originated from an External Source. Please use
>> proper judgment and caution when opening attachments, clicking links, or
>> responding to this email.
>>
>>
>> When ACPI is enabled and the system booted with ACPI, BUG() is observed
>> after merging the static event channel series. As there is not DT when
> [NIT] : s/not/no
Ack.
>> booted with ACPI there will be no chosen node because of that
>> "BUG_ON(chosen == NULL)" will be hit.
>>
>> (XEN) Xen BUG at arch/arm/domain_build.c:3578
> Is the bug seen on the gitlab ci ?
No, I found the issue while testing the ACPI boot. But going forward we will
add this in our internal ci.
>>
>> Move call to alloc_static_evtchn() under acpi_disabled check to fix the
>> issue.
>>
>> Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property)
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> ---
>> xen/arch/arm/setup.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>> index 61b4f258a0..4395640019 100644
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
>> printk(XENLOG_INFO "Xen dom0less mode detected\n");
>>
>> if ( acpi_disabled )
>> + {
>> create_domUs();
>> -
>> - alloc_static_evtchn();
>> + alloc_static_evtchn();
>
> Can the code in alloc_static_evtchn() be guarded with "#ifndef CONFIG_ACPI
> ... endif" ?
Not required as acpi_disabled will take care of that. acpi_disabled variable is
used to avoid the CONFIG_ACPI.
Regards,
Rahul
|
