[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Mon, 26 Sep 2022 09:40:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/6oxB1QN6CCqPGKi84u4N+pEruVVtZFmB1mmYLrlZP0=; b=bQoOhB7j4zu2ZgsxqgCGiuhqODbNsOTHvvkyMxg2GIhEZwwYxBp7WONTEm8TMnlGJY8IFsKicvOuj5FQozol8iQX9G2j1rfK1E40Tz+uCOJ78ZzjxhEQ1/lh4N+0QrL8+UlmXY+XvehUDsEV1wTiXEcWh0usOyBdTM9lYKuoNT5uP76TkhrvdlVHcDqQUHCuMV0Gc0sl3fdvLgZxk6b0dg484J/qxUnNrbL7pMx1q+7z6TL1ewJCJjoqu7IprrCQAYhGPPFRLiijZS8/CJUB2CLruV7iZwYy9107UBDibuEbtW4xQuQ15920GaqMCmlxXdtpL2JYMrfo0yEqDbViUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyKA7S9l3p+Jvj6hdpV9KJjaKiMH+WXABQAt/+0cfOFp7xY8QKqABO08Pmo5nfH5SdjduyMAqZcsz7oPFh/xo5V+o1McawejbwQH6rvKzLP1bBj8opj/EtR5C/Qw91HzKLwnrj2pfb1XowY7DuCu1xNzlBY5lPTiwIF/1oI4IFUA43vYRJGu/AxArgjoc2BIH4YYZjYk6PzBZ1pof5JbQ1bo1C7AfjOLiUxI4M7oFkbY38/2++C1psLqVocJW0bpofMrCOPzOqnkA+rQ+yMWwP7YHp1otwRFZ1Jf1H54E+tSiHQIC1mN5UmnMKoWJgjLq3LvFt4nWXlKAPNsDcE1iw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 26 Sep 2022 08:40:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/09/2022 08:38, Jan Beulich wrote:
On 23.09.2022 14:10, Ayan Kumar Halder wrote:
On 23/09/2022 12:02, Rahul Singh wrote:
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
printk(XENLOG_INFO "Xen dom0less mode detected\n");
if ( acpi_disabled )
+ {
create_domUs();
-
- alloc_static_evtchn();
+ alloc_static_evtchn();
Can the code in alloc_static_evtchn() be guarded with "#ifndef
CONFIG_ACPI ... endif" ?
This wouldn't help the issue, but at best code size when !CONFIG_ACPI. When
CONFIG_ACPI=y, acpi_disabled might still be true, and hence the function
may still need skipping. Apart from this I'd also consider it odd to have
a non-ACPI function have such an #ifdef ...
I think this makes sense. Also Rahul's previous comments looks
reasonable to me.
Reviewed-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
Jan
|
