[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
- To: Rahul Singh <Rahul.Singh@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 30 Sep 2022 10:37:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Og+NroRc5H16Hufeu0AtsVJ2qr8qFDmqiSiAVm1Xa8=; b=D7kq+iWlGwngbTYk0jmJdQFC/77ugOnAS9ibrLXZgjQKtbOT/AA2LBE0WphVOgRY2B2lbbGp38AXNU6ZovFdh9BJx1D/uymRlKDkrzZ1VSIlinMtC2OUg5dgj0TX9HDnREMfjcrI9qE8JdVact0lt2/uCNKxIGU0NRMzpQmjaGqFoXhDxEvq17i4G7byYCR6zJYsCh/bjp8gI0oDKkxa/kpTyoAXYIKbsXAo/him5A0WwdFpddVNMvGKqeTskjKS1c3YSL3ouRGCOLM97Yc6vW8jtj517VTW5cjniDPjseg0p07+FxGg+BvD6H3BncnMsSsIR7SLfGkGJnyXK1pCMQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Og+NroRc5H16Hufeu0AtsVJ2qr8qFDmqiSiAVm1Xa8=; b=bXSXXthqIDpW/DrRmreDOxJM2drA4I/e3zY+Dm+rJkddrTTKmQQr6lUADvSi7sHrQFatKftXOMJngRwC1LvlvYgOxZoC9S0eIBYrmi46r2BgrgEMkMeGQQBDjY5O9ZUGesbOB4xBlgiE45gfYLla/hK44zr9a44Ihr1sEl9dGvUZBWILCm721n7xFH+szEiXvBwJ4KjIYYe/zH73ZqK5klQk1WKBY2KXEkITc4At/hZP9B8hxT7ChIyT/HMmWul/laWqTVb8VcpTAhYpnQr1uHd/xNiCLCyv92U2VKDvDufKxG9cg7SVbiSS0ozgmT65lktUUOZR9m8bgur2n6gTBg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wyt1gxEi6zPs33FoiqOx0WUtwOFXTLzwGfaPctQ9PyzOKeRjrMfuvH2467S8kdH6wFgCyanZrh+ZAJP1ivDMbMJBYcm44l7xLVjMT9Jvw/XQFLfSACVpJrgRJCu0zwjl2lDShXNY8CMII6t24etSt4zN8ifF8j5yZ+kdibfBcIf8s+AWGmk49Q9WIvKn9yo9Qd618kGPqPdpy0GVrRsW22LQr9+894Y3lojtwLehGq3KOT7eR7rm4xYZu1QKDOjQP920Enw+R5F0p+XuBZHf9Nk9+2e0JXPtwHiWzbBSC0+cflH1kimFn0Vlu5bUiquyJO4kHWonWsPjxPrq8tkv2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hUd0VOIzXF1NXGP1+pRTZF6OO/DvsTXFvKyOOh7WG9Syp9i7ETXKA/moo8MinJaW6W7h2AOT04Qnvo6wrCp2Phl39JEX/GxhDKxoKGtIM0TX1b3dr2E0Hp/IFHuAVbbHLCWFNUANfbrWfZEOKM5GF25FiiBRK8ILpgHbNkXueHzAtRoGq0eFsMUyVqzLAl5zVC4piVDqtA2MtiTeOA342O+wHrNeqGuf7VV7YA6QfIvJfo4bPXDOiIkdH+Is51pZG2SBQqjaM5QMFVdHdHBoDHL+769BLl/bDdWm0r7leCmISEJuWuBI5gF18HtKdT36SvbPLJRdseJ9AqkFO3EY4A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 30 Sep 2022 10:37:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYzzwi5SkcTjaGIEa7tDBb5ugVda330q4A
- Thread-topic: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series
Hi,
> On 23 Sep 2022, at 13:02, Rahul Singh <Rahul.Singh@xxxxxxx> wrote:
>
> When ACPI is enabled and the system booted with ACPI, BUG() is observed
> after merging the static event channel series. As there is not DT when
> booted with ACPI there will be no chosen node because of that
> "BUG_ON(chosen == NULL)" will be hit.
>
> (XEN) Xen BUG at arch/arm/domain_build.c:3578
>
> Move call to alloc_static_evtchn() under acpi_disabled check to fix the
> issue.
>
> Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property)
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
This is needed to fix ACPI build issues and was release-acked already.
Cheers
Bertrand
> ---
> xen/arch/arm/setup.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 61b4f258a0..4395640019 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
> printk(XENLOG_INFO "Xen dom0less mode detected\n");
>
> if ( acpi_disabled )
> + {
> create_domUs();
> -
> - alloc_static_evtchn();
> + alloc_static_evtchn();
> + }
>
> /*
> * This needs to be called **before** heap_init_late() so modules
> --
> 2.25.1
>
|
