[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
- To: "haoxiang_li2024@xxxxxxx" <haoxiang_li2024@xxxxxxx>
- From: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
- Date: Fri, 20 Nov 2026 22:06:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6BW9So5iU26l3P6rzikNwUbKVw0vv5K3GCUle3XnEM=; b=RUn9Hl0RmCbwesmiRvWH1nCchz+1Y6JG0hOHENormzXvvoVhrzIZazBQC7ry8A3RtRdcV4Odv3X5/F5ATTu2wYc60ktVctv930BXsjvHlC/frn0pBaA4tPM7gPm52upxYAVvIZd/CaR/yVvXJxcq2Vf+ds8VbAUZYkbYCbtcDPiqENt4or5XGF2ZYuW+JV0RGPl0SA0fPHCSQ35C/7QtEsd51M5pyGY06oEUNyA4Vp3uw+GWkZitPc5KlwO9LMvspYty2jaQ35mg0eyXRTjuCuOj/GEy0krmt5zk2gT47MsViz6DNOhrnem1urJWpC6oRfI/nTU0uVdxNk1SkjgpEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pq3JHCWONzwXCVJgKOFdgpmJD0QH7HQrVnkHU7jXyHM233h4Gaeq8En3B0rcO6y2uMJ2dfPelvi+A54eWiKI8lgt2hERu92VMAQPzl4S05lU2F5GL9O18raLQe4H9vk5v4WL7S05Yc9NSv/pjA6w08JXU1ABb0ABCzo8nT48b2kM6NNCOGGSGvJm2mBr2+ARy0pnbflpaiByctsnTzZkoHcYyhVR1mTEGxkvk1FdpBLsyroi+focuf8R+HmMpRVfZdRwV0yH8Gl+1H8IuuURhrJZXT0H/ItWnlAR93uHh9zOX2wsWdC1RmuTJdLOjoxkQ0ak3SO6iZB1FsbwDIXidg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=Intel header.d=intel.com header.i="@intel.com" header.h="From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:Content-ID:Content-Transfer-Encoding:MIME-Version"; dkim=pass header.s=selector1 header.d=intel.com header.i="@intel.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "Ostrovsky, Boris" <boris.ostrovsky@xxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "tglx@xxxxxxxxxx" <tglx@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>
- Delivery-date: Fri, 20 Nov 2026 22:07:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdeHw6R1wLhKDc+Uq86658gggvibc2duyAgAEPBoA=
- Thread-topic: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
On Fri, 2026-11-20 at 13:56 +0800, Haoxiang Li wrote:
>
> At 2026-11-20 07:18:03, "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
> wrote:
> >
> > If the PV guest hits this scenario can it survive? I don't know xen pv very
> > well. Does this means that the PV guest has no disk or network. If so, the
> > user
> > is probably not concerned with a one time memory leak.
>
> Thanks for raising this. I tested an x86-64 PV Dom0 under Xen 4.17.7 in QEMU,
> using ata_piix for storage and e1000 for networking.
Ah ok, in dom0. (not xen person here)
>
> I injected -ENOMEM immediately before the initial MFN-array allocation in
> gnttab_map(), after arch_gnttab_init() had succeeded. With and without the
> patch, gnttab_init() returned -ENODEV, but Dom0 still booted to userspace.
> In both cases, disk I/O worked, and the network interface could reach the
> QEMU gateway.
>
> However, I agree that this is a one-time leak with limited impact. I have not
> demonstrated any further user-visible consequences from the leak.
Not that it's impossible, but at boot we could expect allocations to be less
likely to fail.
I guess since you injected the error you didn't hit this in practice? If so, I'd
think this would be a pretty low priority fix. The combo of rare scenario and
close to zero user impact. Fine to be corrected though.
|