[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
- To: "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "haoxiang_li2024@xxxxxxx" <haoxiang_li2024@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Ostrovsky, Boris" <boris.ostrovsky@xxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxx" <tglx@xxxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>
- From: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
- Date: Thu, 19 Nov 2026 23:18:03 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YKZNjksr+gQLmbQ8RqiWYDejVUTRGF8MbDFWLPGAhow=; b=CgbLWCU+4kkrFTYufgZ1Djia8SVq82LB+dykOsgEx76C5ENWlGUn9VKkJ5CHvkZdViCzUmK35w00xt1/oT67aGaoGA8YRPBWoHNezSsxFbem7BjzEHpzQ9ENvvDHMW21touWUQh913jXYp4SnHDjr+91P60XuwdGEuUfXETnhJZhgezjgWqhfbY0HNYjKyjTooxj1P8kMj/59XmUukt+OZ1Itgv3nxCfa7oK+cAwSKymKHgFXcnMcAS7bFSqrFX/pK5vpR6OMHfF4S7SlPUcOLliPmZ8g3HN8iLheUerCaFi8oDhQeDp+vxKt9+3Fy3ISm4an+yW+Rk4W8FOBkRj6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aw6bXtt4MoEAHbXRwX8XWbbKGnW+KuVVvBy7xg7A5sVWotVdOVhDmPfhg7UEO2foACFjDww4D/kFG+TPkz4v19ao/qzJs+L+JfAsd9dAxdTe7r90sxhG6ZfSxtWO29ONlcQRY6GPh0m2h1QO1DH+rdHFOnZloyJ6iQNjjsDAH+NPiwmqNpIZnoUFBJ65ZWMnJmlkKCu9VD1GfbszwWlPeXzEiNpfWhl7MEGnUgXDJTmrDrbhdsJtCADpzyy8ZdvAukV0ou8xTFrcKgs7fEU7+KXCQl7SjUV5UQgG7Yo/OQWnH/gM3VC/UGhWz+aV4dS0XMVHyaz8ahV0xoOixqmSFQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=Intel header.d=intel.com header.i="@intel.com" header.h="From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:Content-ID:Content-Transfer-Encoding:MIME-Version"; dkim=pass header.s=selector1 header.d=intel.com header.i="@intel.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 19 Nov 2026 23:18:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdeHw6R1wLhKDc+Uq86658gggviQ==
- Thread-topic: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
On Tue, 2026-11-17 at 16:43 +0800, Haoxiang Li wrote:
> For x86 PV guests, arch_gnttab_init() allocates virtual address areas
> and PTE pointer arrays for the shared and status frames. These
> resources are not released if the subsequent gnttab_setup() call fails.
>
> Add arch_gnttab_free() and call it on this failure path before the
> existing cleanup. Provide an empty implementation for ARM, which
> is also used by ARM64.
>
> Fixes: 162e37171276 ("x86/xen: safely map and unmap grant frames when in
> atomic context")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
If the PV guest hits this scenario can it survive? I don't know xen pv very
well. Does this means that the PV guest has no disk or network. If so, the user
is probably not concerned with a one time memory leak.
|