[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
- To: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
- From: "Haoxiang Li" <haoxiang_li2024@xxxxxxx>
- Date: Fri, 20 Nov 2026 13:56:55 +0800 (CST)
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=s110527 header.d=163.com header.i="@163.com" header.h="Date:From:To:Subject:Content-Type:MIME-Version:Message-ID"
- Cc: "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Ostrovsky, Boris" <boris.ostrovsky@xxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxx" <tglx@xxxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 Nov 2026 05:58:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
At 2026-11-20 07:18:03, "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote:
>
>If the PV guest hits this scenario can it survive? I don't know xen pv very
>well. Does this means that the PV guest has no disk or network. If so, the user
>is probably not concerned with a one time memory leak.
Thanks for raising this. I tested an x86-64 PV Dom0 under Xen 4.17.7 in QEMU,
using ata_piix for storage and e1000 for networking.
I injected -ENOMEM immediately before the initial MFN-array allocation in
gnttab_map(), after arch_gnttab_init() had succeeded. With and without the
patch, gnttab_init() returned -ENODEV, but Dom0 still booted to userspace.
In both cases, disk I/O worked, and the network interface could reach the
QEMU gateway.
However, I agree that this is a one-time leak with limited impact. I have not
demonstrated any further user-visible consequences from the leak.
Regards,
Haoxiang Li
|