[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86/vlapic: size the all-ones broadcast by the sender's mode



On Fri, 20 Nov 2026, Jan Beulich wrote:
> On 19.11.2026 23:00, Stefano Stabellini wrote:
> > vlapic_match_dest() detects a broadcast by comparing the destination
> > with all ones in the target's mode, but an IPI's destination has the
> > width of the sender's mode.
> > 
> > Use the sender's mode when there is one, as is_multicast_dest() does:
> > whether a destination is a broadcast is decided by the sender. vIO-APIC
> > and MSI destinations have no sender and are still compared in the
> > target's mode.
> 
> But that isn't right: Those simply cannot express wide target IDs. Aiui
> 0xff is uniformly "broadcast" there. (Or alternatively 0xff cannot
> validly be used in x2APIC mode, or even at all. I fear different sources
> say different things as to the validity of this.)
> 
> The situation is perhaps yet more fuzzy there with the 15-bit ID extension,
> for which patches are floating around. All we've got in the tree so far is
> XEN_HVM_CPUID_EXT_DEST_ID afaics.
> 
> Overall with no sender it may be best to simply skip the broadcast check.

Is this what you are thinking?

if ( source && dest == _VLAPIC_ID(source, 0xffffffffU) )
    return true;

Note that this also drops the physical 0xff broadcast from IO-APIC/MSI
to xAPIC-mode vLAPICs.

If 0xff is uniformly a broadcast for IO-APIC/MSI, the alternative is to
accept a physical 0xff from them for every vLAPIC, independent of the
target's mode:

case APIC_DEST_NOSHORT:
    if ( source ? dest == _VLAPIC_ID(source, 0xffffffffU)
                : !dest_mode && dest == 0xff )
        return true;




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.