[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21 04/10] x86/HPET: ignore "stale" IRQs
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 17 Oct 2025 14:13:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eqdVnM9UB/NU7VlYk/QtKZ96CjsOV5qDJup6Au8WHGk=; b=GnbmSA2r7HhJ/YuB8tchNdO719cmW9+7XlNv728uCtbKrSBmvOPlBJk4Jj5e2jKWCj+G91xpumyyb4rpzqKPMYBQ3awlKUS2MBZt+i+Rid9QsHpLoaX5Xqj+IjQpVx7rk1M4Zw+vhUO9Rxg2gIZkgvaB8ffK3ISebvFy5JQR9M8QuMg021UWlyTeLKS0WYS5J5Seg2mH7IwI97ZdDXK4pBwHk4eoxWpvslekTDjLa1iDMo5VQeoc/crVB3WKuARLlwtm8JunJzZDjMmUVqDPhtDhObJFuVeItYUc5VApt/p+AAwuRdWxuu8Q7dm2tMyurJxluDRVvlZRx3fxh7ZLpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ysYngEHnL2R/YuXJf/+QCQNYmofcAsDoCMlBpaqFzrCx2J5k7y2t75EG4Cbgeng72Dbfjw6TEeId/bOUuiVPcBYF/mfUnSshfLxUl2EkOrROSPQlym5GKLU3IDpNxo0+aH0ovvAIy158XL+LH/vYz4A5oQrhE/AK9z13x7O1jcAMrOG7cy0gsIj+Tv5bTyeQVKcx+KtPPUK+vMZz/c6ZsLVRe4ryaovm/LMXpmsp6Qy2Pb5GWyVEOniH7D8NG7FqdZHTMmc4JT2DYkzPvzg3BhGUJAjWNGVe4A7JtHruiNBL4kfkITSB7w6QqQJGK/pMEOXSCxJb72lZJICliSbkCg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Fri, 17 Oct 2025 12:14:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 17, 2025 at 11:57:28AM +0200, Jan Beulich wrote:
> On 17.10.2025 11:19, Roger Pau Monné wrote:
> > On Thu, Oct 16, 2025 at 09:32:29AM +0200, Jan Beulich wrote:
> >> Following hpet_detach_channel(), IRQs may still occur: Ones may already
> >> be in flight (both from before and after the last IRQ migration, i.e. on
> >> possibly two distinct vectors targeting two different CPUs), and new ones
> >> may still be raised as long as the channel is enabled.
> >
> > Description would need to be adjusted if nothing else, as it speaks
> > about two distinct vectors which is no longer possible after patch 3.
>
> Oh, right - dropping the parenthesized part.
>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > With the above adjusted:
> >
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Thanks, but as per the RFC remark: Do you then think this is actually
> worthwhile despite what patch 3 does?
I don't think it will hurt, but I also think this can possibly wait
after the code freeze, I don't see much win from doing it, and there's
a risk we might get it wrong.
Thanks, Roger.
|
