[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8] vpci: Add resizable bar support
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 14 Feb 2025 09:01:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=45iqNkxXBPv+1X0OuQFk5ayq1jVtDKR0WVl00qKrLAA=; b=M9T1Ukn1tETx262NpzPg0Oh+VEknXFB/pRDbABcef90MpiLOYHyNw9+UyhFUPdGefUQ9jHKMTkqRqhE5sIp2Sdf3W3ovi6J8+caqOMR/VO/IhFWSM9aVkSJNfB/HLv1dLK0oEnJ8DW1kWUHmFcsIVvBQh6G0yK1z6C2ZhbkYxW8NY3kwQKrshMZP880vC/ZORLW9ZZF77KohLOOScN+BFSbAyI+NiQSpO57kK0fu6n0tz/AbR2yBvTmQTJJNtApODzzl6fIPvXL0HdlrKDledgb1tcLL/c4yMcdrJIuu0MUxlTAee20YUpQmzYViR8Jx0PfOOwXS1JOnnx2AwVLwFQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Nh3oWotrhUS/RX4XH9S8ebxcMiPzZ2NVsEJVubroJws+7RCEGP4GlHnYGdsvBmxY7iAzXO5N/QAKTEykNkMxRm67ZlBJlu5hf55coo7AnXU3mOydihO9uW6feTo5QoFNvgStHK5/5wjeYdZDD1z9Y62H1XzhqcRI0Udw4pmbACrb8N2/OIKR3+nrAP0XTpIMpxCdHzkEwZikGZ2Bd+zPKI2+woGNSu5VJ1oQ+BWMT6Zk7NeYPpBtnsSCQYbSvnvMEmv2igGeu36RymeCbZfoVpiRq5SUNhrlnE96r1qOhIM98HyH9Dzpzr17dfge6/p1n/W0FLfeETxPK9WTNIqyOQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 14 Feb 2025 09:01:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbfCv1LhGDvDdYvUG/cVOOSigHrrNB1FUAgAGqhwCAAu7EAIAAC/MAgACG94D//38EAIAAinmA
- Thread-topic: [PATCH v8] vpci: Add resizable bar support
On 2025/2/14 16:39, Roger Pau Monné wrote:
> On Fri, Feb 14, 2025 at 08:22:39AM +0000, Chen, Jiqian wrote:
>> On 2025/2/14 16:18, Oleksii Kurochko wrote:
>>>
>>> On 2/14/25 8:35 AM, Jan Beulich wrote:
>>>> On 14.02.2025 04:32, Chen, Jiqian wrote:
>>>>> On 2025/2/11 17:21, Roger Pau Monné wrote:
>>>>>> On Tue, Feb 11, 2025 at 10:22:57AM +0800, Jiqian Chen wrote:
>>>>>>> Some devices, like AMDGPU, support resizable bar capability,
>>>>>>> but vpci of Xen doesn't support this feature, so they fail
>>>>>>> to resize bars and then cause probing failure.
>>>>>>>
>>>>>>> According to PCIe spec, each bar that supports resizing has
>>>>>>> two registers, PCI_REBAR_CAP and PCI_REBAR_CTRL. So, add
>>>>>>> handlers to support resizing the size of BARs.
>>>>>>>
>>>>>>> Note that Xen will only trap PCI_REBAR_CTRL, as PCI_REBAR_CAP
>>>>>>> is read-only register and the hardware domain already gets
>>>>>>> access to it without needing any setup.
>>>>>>>
>>>>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>>>>>> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>>>> Thank you!
>>>>> May I know whether this can be merged in Xen version 4.20?
>>>
>>> It would be better to merge it after the Xen 4.20 release.
>>> (It will happen in the next 2 weeks).
>> Got it. Thank you for reply.
>
> Could you also add an entry to the CHANGELOG.md file to note that
> ReBAR is now supported on PVH dom0?
Sure, I will add it in next version. And I think I need to wait until there is
a 4.21.0 entry.
In SUPPORT.md, do I need to change the sentence " * PCI SR-IOV and Resizable
BARs." to " * PCI SR-IOV. "?
>
> Thanks, Roger.
--
Best regards,
Jiqian Chen.
|
