Re: [PATCH v8] vpci: Add resizable bar support

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 2/14/25 8:35 AM, Jan Beulich wrote:

> On 14.02.2025 04:32, Chen, Jiqian wrote:
> > On 2025/2/11 17:21, Roger Pau Monné wrote:
> > > On Tue, Feb 11, 2025 at 10:22:57AM +0800, Jiqian Chen wrote:
> > > > Some devices, like AMDGPU, support resizable bar capability,
> > > > but vpci of Xen doesn't support this feature, so they fail
> > > > to resize bars and then cause probing failure.
> > > >
> > > > According to PCIe spec, each bar that supports resizing has
> > > > two registers, PCI_REBAR_CAP and PCI_REBAR_CTRL. So, add
> > > > handlers to support resizing the size of BARs.
> > > >
> > > > Note that Xen will only trap PCI_REBAR_CTRL, as PCI_REBAR_CAP
> > > > is read-only register and the hardware domain already gets
> > > > access to it without needing any setup.
> > > >
> > > > Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
> > > >           
> > > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > >         
> > Thank you!
> > May I know whether this can be merged in Xen version 4.20?
> >       
>     
It would be better to merge it after the Xen 4.20 release.
(It will happen in the next 2 weeks).

Thanks.

~ Oleksii
> That's a question Oleksii would have to answer. My take is that it's (far)
> too late in the cycle for a feature addition.
>