[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8] vpci: Add resizable bar support
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 14 Feb 2025 08:22:39 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I4odUrUD+4Lk+vyiBeVsxHvbeYQwWngnzbZb+0vclcc=; b=AuxnnxHdykz8FfBQhkbGQYzlZwVxZW/Kk7jddY2WD834U1EIjRfZA1AwXZspqBOHP2uFOhrotdAm9tr067jwE91wTNXPDLLlTD8hM8dTZt0dR2Ay6cZ7uFH23HL6rgt6gYUIu4SoMg19Gu/75jfhF7OtNUQIaWFSrn+tD/r0tiBEfWIfpDCN+5Fi5n/3HhZW5o8kX4OchnuZOKhzDa0QXsgYmfhvkg33+txOClAxePoNp291OPP1QccOhCfKPKUQjwCDrSu0k0Kkrw9/KW9DJNcCt5lxSnZFOMdMoGSq09TNUmynTixd0UNIsCiB4lM9h9tv8FZ7hOiqaNjzXVyI4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f3/ekrGllgoRvf/zAonOsFXwAhdfLm9KtgzzrI5y/a3JbSJegewY3xzeCuK6wGOnBRjy1laChckb2LuaMoDj2YkusWMhdancrS+DOQJeStoOu+d3+aAAjhQeQhEI3mRh517T6yR2pCnrN3aOhlB1hhszHS/0ioTruM/xGcKUVOL6jwuO0McT6FlVdOyw3lgdT2ALjzIXYW/PCUErKQHgTmw+k3jas0RMwTYKj3oHIYzVQ/DFP2vu0sd4000HkAkKuJ8qmZx47gPq6/V2R7/cPwFVmz28vIy9EjzuoUzJo2IdRu6jOnFYPIbtX/WvYb+bzBNDGBsRZu/y1z0YeS7uqg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 14 Feb 2025 08:22:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbfCv1LhGDvDdYvUG/cVOOSigHrrNB1FUAgAGqhwCAAu7EAIAAC/MAgACG94A=
- Thread-topic: [PATCH v8] vpci: Add resizable bar support
On 2025/2/14 16:18, Oleksii Kurochko wrote:
>
> On 2/14/25 8:35 AM, Jan Beulich wrote:
>> On 14.02.2025 04:32, Chen, Jiqian wrote:
>>> On 2025/2/11 17:21, Roger Pau Monné wrote:
>>>> On Tue, Feb 11, 2025 at 10:22:57AM +0800, Jiqian Chen wrote:
>>>>> Some devices, like AMDGPU, support resizable bar capability,
>>>>> but vpci of Xen doesn't support this feature, so they fail
>>>>> to resize bars and then cause probing failure.
>>>>>
>>>>> According to PCIe spec, each bar that supports resizing has
>>>>> two registers, PCI_REBAR_CAP and PCI_REBAR_CTRL. So, add
>>>>> handlers to support resizing the size of BARs.
>>>>>
>>>>> Note that Xen will only trap PCI_REBAR_CTRL, as PCI_REBAR_CAP
>>>>> is read-only register and the hardware domain already gets
>>>>> access to it without needing any setup.
>>>>>
>>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>>>> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> Thank you!
>>> May I know whether this can be merged in Xen version 4.20?
>
> It would be better to merge it after the Xen 4.20 release.
> (It will happen in the next 2 weeks).
Got it. Thank you for reply.
>
> Thanks.
>
> ~ Oleksii
>
>> That's a question Oleksii would have to answer. My take is that it's (far)
>> too late in the cycle for a feature addition.
--
Best regards,
Jiqian Chen.
|
