[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/5] xen/arm: enable vPCI for dom0
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Wed, 25 Oct 2023 15:32:26 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bQm9qLEtiIOT8W5ejlBLBEidgM2aFzVM7WxqrAwHOgo=; b=bQAZB5NYsE5IU4qN1RnHlrIRKI3XHxMah4RMyDhcDddCpnjqaDFkpXH5YbKBYeHErRUnj3jjU9lVluMPwuA8V3hhD5YzdGuhjQm9iXWU6dEe+lV218lAH40x9LjfRnuQiwGYYvp2WjFISvxD/rpvIu+gquMjNCSboIQKyl7vYm6NHRTidn9fzYlOXOyDzak4ehRP8d/Bkynsyc726zmndrHrpImdT7sPlKDpNpwgCEhn75qmD/DVnu8leMS7rriGZpdyap/larH3Jcy74WHS9tML3c1HoZKNzcpV4LtAVlVASa/feMBzjah89k37HThDv6l6ilYHfhRsCSOgk2/E1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISAnZKwR3xHGwsFrWJyMY8yxpGWFuMhmC/ZJ3OkotgXExI6A3JRfljSeSCZ59xePdKgUo0bB8tC2sx6PfiJnkdCiSnPe1SMPOaHd3PAUNMIIIJo9wcX/YvhOdXugI/sj1xIuNTqrESsFUyhi5apFP+fU2AP4ZznA+Ib43nDzItxB5XoTn4gKcqfJZ2w7KgriNXC+0qYHFTSZaS+NES2Gpz/1/60g+QiKbBOqlzf2JBpnFyA+qgT1MlMNlMZ0Pifdd31iLM0Of7jEqo21pO+U4r8JLpCEx7n8Ly2+KJUXXZJ2f1sc4RxjYR6bLZ56WRS3L6gz2EALzlZlNYZqGSd8kQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 25 Oct 2023 19:32:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/20/23 13:33, Julien Grall wrote:
> Hi Stewart,
>
> On 09/10/2023 20:57, Stewart Hildebrand wrote:
>> Set the pci flags in xen_arch_domainconfig to enable vPCI for dom0.
>>
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>> ---
>> Julien had a suggestion to make this conditional on pci_passthrough_enabled
>> [1].
>> However, in v5 of the PCI ARM SMMU series [2], we propose removing the
>> pci_passthrough_enabled flag. If pci_passthrough_enabled is gone, the
>> conditions
>> under which vPCI should be enabled for dom0 aren't entirely clear to me
>> (other
>> than CONFIG_HAS_VPCI=y).
>
> I think it should be based on whether Xen detected a PCI hostbridge in
> system. I haven't looked which variable/function could be used in Xen
> for this purpose.
We can slightly tweak pci_host_iterate_bridges_and_count() and use that.
Also, a full revert of the pci_passthrough_enabled flag over in the SMMU series
probably wasn't the best approach, so I'll add pci_passthrough_enabled into the
mix too.
>
> Cheers,
>
> --
> Julien Grall
|
