Re: [PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

[Julien Grall <julien@xxxxxxx>]

Hi Leo,

On 16/10/2023 14:54, Leo Yan wrote:
> On Mon, Oct 16, 2023 at 01:40:26PM +0000, Bertrand Marquis wrote:
>
> [...]
>
> > > This patch enlarges identity map space to 10TB, allowing module loading
> > > within the range of [0x0 .. 0x000009ff_ffff_ffff].
> > >
> > > Fixes: 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable")
> > I agree with Michal here, this is not a fix so this should be removed (can be 
> > done
> > on commit).
> This is fine for me.
>
> I'd like to confirm with maintainers that should I spin a new patch
> set to remove the fix tag?  Or maintainers could help to remove it
> when pick up this patch set.
I can do small changes while committing (updating the fixes tag is one).

That said, we are in the middle of the code freeze for Xen 4.18. Any 
patch requires a release-ack from the release manager (Henry). I am a 
bit split at the moment whether we want this patch for Xen 4.18. So I 
have asked opinions from Henry (others can also provide some).
If it doesn't go for Xen 4.18, then Stefano might be able to queue it in 
his for-4.19. Otherwise, it will be picked up when the tree re-open 
hopefully in a couple of weeks time.
Cheers,

> And thanks for review, Michal and Bertrand.
>
> Leo
>
> > > Reported-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
> > > Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> > Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> >
> > Cheers
> > Bertrand
--
Julien Grall