[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 1 Sep 2022 13:52:16 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/IrGcB7LR9nYX8o1o0wOpvZ9jGcCckMW0Z3W7YPZ/Wk=; b=Q2M5v5C26Jwz8+yrep4kC7Pidk7ixLw1DvFrZaJ9DjamWgR4bKtKImVFcUgJ65IFluJP9dU0Xfk2QwO4ljFL9FAi0kX/j6FCD4r5Qqe5ZW8CyntZb1HMXjeJ//ntsVppgocyCSvlb6/Zf/Ve6LiX4S0EU7DDf8Zf3oRNI+hMBNFyvZg9RZtSFAbWBeEiT78PiEM9vqu6/pz/it4zKIDSYLuGWf0RxUQx+nZNHcRJIMOcQQSCxKBhR1FHGVOSDVktdQ8xkX0MtEW+BIkmFOGP+gMNQLgcRM5TAhb1KUjr5edFDC2nPdxgQy4/rT8mdrbtyEKnsjcJ3wNXDu0ACiO6rw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/IrGcB7LR9nYX8o1o0wOpvZ9jGcCckMW0Z3W7YPZ/Wk=; b=STtGODAGikB+49bpOscgZyt61tBtZxSV+PGW1Oxx8rba0JHFCB0tUfyeEH/kvdwXuEsDYpo+Iiv+dlCb40MtYUbHpVawwyN1T9wK3tkQY/+gs8qRzqFN0kzGn91A2iVHtaOcdioq282+czCKUY4EPOwaPEMplXKi2/WV2T/kHcQQ7UESuVOfhiGr3FX9uD8aOmKhvqVAuUQesGMs3RZxKYa7IY3+f5rOoW8BOhrvxVXDiO3pTUnSN45HlX0ZK1IsFr6EWqKblrK1+3kgqCqKkihxt9TsiSge2ud3EZVbWN3jUhgcBaNavI1uv2obcYX6EI5B7YynbvMJJi/jjmOfPQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hZOhYPssheq99qoZf4F2PCQfcDzd5N8+xHbQKg/OOtIOW1G/4PBt9rgK7PKZlrJ2tIdx0IUrAGx8OGac6fIx2owUDZbCXhKWHZUTFyMqyC7gl7BJhqGajRE4dnhibnvpz6BvmsM9yoj8IV0T1gN9lV6O8QOxNkRR481QFI8VTlZw8WKn62d4i/P/cdkDlfgU4CsgJgEJewKv/Ok8L9hGu7UK0XNpOelEHB6jOw/i/hAnCxUIibhEXOapjMtlqP2C2u9/d1Mj7K/jp6hz/jPgH+GSw0nPy88wwiskY6Tn562KnOvUy1qhBquSw868mCrZkE5FjxsHCmS/nghYBUKwiw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8F+OC8lpLQN9Gijfrvf4k1unIY5wxBgqfR8g8HFDMx/9rSPEEjB633Z7N4t1uA9C1OEiWoiTYZZzpi2ChITdUVbWegk//P51DaycUswSk/G4JGF7M3+moUYyraWJbBA2qeqqRNbFItBrGb/TIl+mZoC0n68odGJmJLHk8Gxd6xirfVPj7FMVkNhVYNml61xUKLnl30S4QZxfml4H6EphPTd9Ep4HP/kieCuprMZZyzkr0q2w7V7QyRQD+Q3mX8yaGX8N8IduDqsZmqyRZuFIc20qrlqpE6ppQd50c8dlLCZAsViRHMvWfcmwXSQKy4wwiPZCXwgCofLRyvMqrpVfw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Thu, 01 Sep 2022 13:52:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q2/e0SAgAeAsxCAABaogIACundAgADR+ACAAAOZ4A==
- Thread-topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
Hi Bertrand,
> -----Original Message-----
> From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> > On 1 Sep 2022, at 02:03, Henry Wang <Henry.Wang@xxxxxxx> wrote:
> >
> > Hi Arm maintainers,
> >
> >> -----Original Message-----
> >> Hi Henry,
> >>
> >> On 30/08/2022 08:11, Henry Wang wrote:
> >>>
> >>> Hi Michal,
> >>>
> >>> Sorry about the late reply - I had a couple of days off. Thank you very
> >>> much for the review! I will add my reply and answer some of your
> >>> questions below.
> >>>
> >>>> -----Original Message-----
> >>>> From: Michal Orzel <michal.orzel@xxxxxxx>
> >>>> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot
> >> and
> >>>> heap allocator
> >>>>
> >>>>> This commit firstly adds a global variable `reserved_heap`.
> >>>>> This newly introduced global variable is set at the device tree
> >>>>> parsing time if the reserved heap ranges are defined in the device
> >>>>> tree chosen node.
> >>>>>
> >>>> Did you consider putting reserved_heap into bootinfo structure?
> >>>
> >>> Actually I did, but I saw current bootinfo only contains some structs so
> >>> I was not sure if this is the preferred way, but since you are raising
> >>> this
> >>> question, I will follow this method in v2.
> >>
> >> This is what I think would be better but maintainers will have a decisive
> vote.
> >
> > I think this is the only uncertain comment that I received during the latest
> > review of this series. I agree that Michal is making a good point (Thanks!)
> but we
> > are curious about what maintainers think. Could you please kindly share
> your
> > opinion on the more preferred approach? I will do that in v2. Thanks very
> much!
>
> I think it does make sense to put this in bootinfo.
I am good with that, then I think I will move this to bootinfo in v2 unless
other
objections. Thank you for the input.
Kind regards,
Henry
>
> Cheers
> Bertrand
>
|
