[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 1 Sep 2022 13:31:00 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+7aZtzP+3fVzOx9U/mTHQ45+BhoOndlAfsLGSne//qs=; b=XXnXOmNiRQzcJZ0CAQCtJLKelLWxNKt722Ch7rVNcHxEaUGVIVtamHnWEJ2TC2v8NKRxh3euB9SGOScVyqzRF3PXC3bdN/0euc7eGlw4j9WCnbKgJe+65LCgq5EUi7MsaIMMZioUoSStKofk7IyoCYzUQaHcqWJKIZIFcQ4GTcyEwgLJbxs4nehzMr7ZLT6DjZsIk/aYb+DwCpWpETX80MvPAmsWLPueJ58rLJMxADQqVR+X+BgMsKuwfTIlr8YbwiELtG9YEfiIW/eaDBWJ3nbAoqhUqzhMZzb8VeYAfghGv1yw8gIfYw/ybEfEVOkfeZcwoVctz59+vY9mjqkc4g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+7aZtzP+3fVzOx9U/mTHQ45+BhoOndlAfsLGSne//qs=; b=QfANCKfkVwf/M5u3qcHTOt4sagFqdD050S2E2OX5joMKUu+6f1zqHGmET9U+k+lcnFtYsLVS4hc39zxEyWbivr8aJaO4U04mSqveBGMmB0Eh/NbIl/0dD/eto5GAYJcFdMwCagH4rpRWBa1Xq1Hu8vai9hzPKnEpf+2j6RAcgWVYoBOh/mj1HPlxXE9Hzfm1XX9wc4e5/Mra96l5u1Ark3AV9Qg8XW7ogfWsH4v4Dke/33NzGYADxhSB1wqq/7ygVEQ14J9wsoL69RveBQq56XKZcu8m2J/I34IfDX+q7zvSSegT2KVvr30rhi0837P2pxHj8ToYBAe0uIb6vVWQFA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XxW+SG3yDMIqOsUNRLYT9wq2ni/Z/afG6ZDHoPhLXw52urixfCmM+y81iYR7EBtT8wxjUZXb6nuUL4gTZikqwaVaJLFRBvIAkRQNhomOStetdso7XewGO5Ves3MDWcjqea7aN7XYPSluoR4TFvR5jUHfB3xHoPcZMXYnsUPqFpyjL/XokYK6Rc6bzQJdfwrg5EG2c/sJYS1l0weBKR2RNXoymDPOt112tfmnZY2QNF/tP+m8K8UtEOQJbi71uNcJZVc+9xbPWd4tsCMnZt71EzBhtT4d98YVXmCqS8/LvW90QUiN9c0hZpNYnwmv3ynwGWdnuyZuac51xHbX3ukRrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QfVKmqd0DvpwgEdq6NmWsRveHgPknJ0bWrt5B7Zhh77nspr8oHZLg7Ane9GFwxIEq8DVxV08nRU1/iBK5UmCtrd8lcRLi4wz4EoDq+L4/4YDfncVrm6EYAwcH6nfewzAK70kHPy+xxvG2S9wfS1Bxa0byrXkWo1qEfuI7jkdjSixsX3k8wcKGCzOERuuRDpkkjTIyeA9QLGDuYZwO2RWl+cenwGQ1Pt+ePFarFoj6W/3EiI2LDL1gp1emNcFhls5uOpGG0wETfey8x8rfTBmLN/fSScwwd9BWTfTDkBRrdk8YyhnxwVtRHD8MZCU3FGYkKocG48leBxRXl4pFUFp8g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Thu, 01 Sep 2022 13:31:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYt4ugdSSmJYfbb0KQ5sTlqjIZuK2/e0SAgAeENACAABMngIACu6WAgADQygA=
- Thread-topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
Hi,
> On 1 Sep 2022, at 02:03, Henry Wang <Henry.Wang@xxxxxxx> wrote:
>
> Hi Arm maintainers,
>
>> -----Original Message-----
>> Hi Henry,
>>
>> On 30/08/2022 08:11, Henry Wang wrote:
>>>
>>> Hi Michal,
>>>
>>> Sorry about the late reply - I had a couple of days off. Thank you very
>>> much for the review! I will add my reply and answer some of your
>>> questions below.
>>>
>>>> -----Original Message-----
>>>> From: Michal Orzel <michal.orzel@xxxxxxx>
>>>> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot
>> and
>>>> heap allocator
>>>>
>>>>> This commit firstly adds a global variable `reserved_heap`.
>>>>> This newly introduced global variable is set at the device tree
>>>>> parsing time if the reserved heap ranges are defined in the device
>>>>> tree chosen node.
>>>>>
>>>> Did you consider putting reserved_heap into bootinfo structure?
>>>
>>> Actually I did, but I saw current bootinfo only contains some structs so
>>> I was not sure if this is the preferred way, but since you are raising this
>>> question, I will follow this method in v2.
>>
>> This is what I think would be better but maintainers will have a decisive
>> vote.
>
> I think this is the only uncertain comment that I received during the latest
> review of this series. I agree that Michal is making a good point (Thanks!)
> but we
> are curious about what maintainers think. Could you please kindly share your
> opinion on the more preferred approach? I will do that in v2. Thanks very
> much!
I think it does make sense to put this in bootinfo.
Cheers
Bertrand
|
