[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 1 Sep 2022 01:03:43 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LcbC8kkJvMSKdojttAwGwtjlVEAJaFx+DC4gz7xzm+Y=; b=De7aioC45ciCBpwuKzJBiiTXBzJ7MR40E6aw/5cMORJDl21cBm7NTb3C0UzVVB7CRDBGmdyMcR02s1+G4XkiNw1/MIDAKiSGe2MDFH4BuZ03y2dHoZmPvidD1/z2dEZbQ06i8PtHOBeqUuEcbUNNmlv2V5CPyMAEGdeHTiRykbD653gz4Lk+NTmaQVOtH1zc60pYjGY6nbToQbtQQgaLihPKYo66ZsLN6K7NHLjRaf8Y16O4113mpZusCE1kZK2gI8tYIBCoE2C2Pk51pt1FX39LWURsK/7R7UVKR47QLVFZapl4+qSkYimOl483PyeUxisMSxIf6S+U2Zxz1pPzOA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LcbC8kkJvMSKdojttAwGwtjlVEAJaFx+DC4gz7xzm+Y=; b=QdLlXEvu5tiHAHAp5grWV8T0vCTHg01aMUNa0cx28PmTciwNVhO83ZtHcE5EEpomDMPkDeXavO8JKB9zdJk1uqPFDDPPxiAXXCCng/QCU01acdD9r6xrMENnxQQ7tFkZD9mmODQjrbQGyXS3jEmK2ShKROv1oanqCMSDKYyKgdiDGT9AgiK2r6r0yR/S6o/3Q/6JnTuOvTGlemWudUj7w+/u+IDiDd/MFKFXZ0lgQ70gjPRY1XJCEVo8nvL/0IgFbz870Dd0SpsplvmpbpXJxb3A9GkCC8ryNDjMb/HBb5k+zPE6kL2BU6iIP/0Pt0Uxcza5RH/6eaACiNe9c6lWbw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b0D1u/kIBrfrMQq8X2uAfYeCEPoWk/MIKYo2flGw6ESNklcgkaE0iiyeZjjPZosCD/eXwBg1XMIWr/4pn4s6RUYZNTKtgVXD4WNaZyzBcTwEMOpfpObck/fiktYbxl5oTiM63dubJNF8GJDayLvZFdms2EyCRQ2ZaxkIMUZWyQizfSlX/pwuDrTInJXbMU47ePYnsxoAQi0g/W32etDjSb3d9d0Bf+mJBm2XQaNF49N+shibdqYxbxFd8GN8MlP4Vk218BGIDELrLnqiUhr2bN3Ns2C2umTV5oLS76lWtmVFeZp8E9mHaW9J13BW+wEj6yeTvdCnv65xz0Gm/TMVMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgqLxZiyop9RMTT98xssl6j8jdQxqcjc0m+TNpRnBdQadGOfo3Jd+yUob+PjXmp3SFw7Cb+kvLDYhGoWhK97ur51xy1ez+D8uGdWQERF9IwScz/GHSmdd7O4mLnTxQaVkoEXPC2Vm1o+vPXNAtjnNuVgbUFif1hQMZ6VjfnGd/t86Vhw/vWLs50jXlW6ErjnHZFUIjRkyQhtYfHewhr3Uw5pWUArZIr0kA34Tb2THJaGiPbYJmRLCUS2fRRqm9BimrRNZ1iVY109Hui75ZUgDi+Dq975qhx4elspwPBkCh7WB3TirCGBQ3zhy4XlXYIM4bSHIxjcPQsPgiDvd7yUbw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Thu, 01 Sep 2022 01:19:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYt4ugTfbCAM/WyEil7pMplK0r3q2/e0SAgAeAsxCAABaogIACundA
- Thread-topic: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator
Hi Arm maintainers,
> -----Original Message-----
> Hi Henry,
>
> On 30/08/2022 08:11, Henry Wang wrote:
> >
> > Hi Michal,
> >
> > Sorry about the late reply - I had a couple of days off. Thank you very
> > much for the review! I will add my reply and answer some of your
> > questions below.
> >
> >> -----Original Message-----
> >> From: Michal Orzel <michal.orzel@xxxxxxx>
> >> Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot
> and
> >> heap allocator
> >>
> >>> This commit firstly adds a global variable `reserved_heap`.
> >>> This newly introduced global variable is set at the device tree
> >>> parsing time if the reserved heap ranges are defined in the device
> >>> tree chosen node.
> >>>
> >> Did you consider putting reserved_heap into bootinfo structure?
> >
> > Actually I did, but I saw current bootinfo only contains some structs so
> > I was not sure if this is the preferred way, but since you are raising this
> > question, I will follow this method in v2.
>
> This is what I think would be better but maintainers will have a decisive
> vote.
I think this is the only uncertain comment that I received during the latest
review of this series. I agree that Michal is making a good point (Thanks!) but
we
are curious about what maintainers think. Could you please kindly share your
opinion on the more preferred approach? I will do that in v2. Thanks very much!
Kind regards,
Henry
|
