Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

[Julien Grall <julien@xxxxxxx>]

On 30/08/2022 02:04, Stefano Stabellini wrote:
> >   size_t estimate_efi_size(unsigned int mem_nr_banks);
> > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> > index 500307edc0..fe76cf6325 100644
> > --- a/xen/arch/arm/setup.c
> > +++ b/xen/arch/arm/setup.c
> > @@ -73,6 +73,8 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes);
> >   
> >   domid_t __read_mostly max_init_domid;
> >   
> > +bool __read_mostly reserved_heap;
> > +
> >   static __used void init_done(void)
> >   {
> >       /* Must be done past setting system_state. */
> > @@ -699,8 +701,10 @@ static void __init populate_boot_allocator(void)
> >   #ifdef CONFIG_ARM_32
> >   static void __init setup_mm(void)
> >   {
> > -    paddr_t ram_start, ram_end, ram_size, e;
> > -    unsigned long ram_pages;
> > +    paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size;
> > +    paddr_t reserved_heap_start = ~0, reserved_heap_end = 0,
> INVALID_PADDR or ~0ULL
I would strongly prefer the former. It is more difficult to understand 
what's the value means in the latter.
Cheers,

--
Julien Grall