[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] x86/smpboot: Allow making an INIT IPI conditional
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 19 Jan 2021 15:58:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YTDr9KUtJcoAcSIvdox0n3vqGTHIL3tdLx8qQLqmAms=; b=ff9Uo1CerkewTbdSpIcgmZTLWqy5EoMBUv8dl5xOjwzo2QICdrjN+EU02I/Y3W6bqqQNHlVY71jZs0poLutpS97Onc5k766LNto9zDWeY5xcGPUJVeUYX3ieB/OQK3WWoIfhQhl0fpK/qdognLOQCA1AHKNXhAoBuIugYfzLUQjCDd+tY/3GoWwaJtdqg+RU2cxSUCbc5B9uyg2RdDqqBWSlGbBDgLZSo1/sVixoayzt9Rvlnwny4kSBto61DTxvKW2wO9BGrjiaHNdQPTlCbiMGqQVjEarZwM/Z3Q3rW7S9u658OJgQsRML91RIfZjUW0kuBOwFInS+x/zSi1DCrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJsmNXVjMzzWDRILZZ7pbdJh5R49DW7/51fD1dushPRhluj4aeHKleVQ4UFQg6ilVU1ywbsIr7hl+gdXnfNimODjqVhQpwZMCPmEgW5neNxCr1XLRYe+s/elNJsqVUnGe8I4aFm0JDMzzMuHesDLmeOtlosAbCldjf9RwvkS50Ds+oOM3pYg+njhyPWOOJDgHK5dJOmy4FzrieLvVVAqlQUwORDhEi8zMX/Ge9yv2nBZft+UT48bDDjh1nG7Kr5MHLzoCstTinNM/leTqe6/ChkU4v5Z49pN7ElSXUHh2A4w/g8uXSyewGcG5UuLEY6et4xAX8YsRHT+3JycP70WfA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Kasiewicz <marek.kasiewicz@xxxxxxxxx>, Norbert Kamiński <norbert.kaminski@xxxxxxxxx>, Michal Zygowski <michal.zygowski@xxxxxxxxx>, Piotr Krol <piotr.krol@xxxxxxxx>, Krystian Hebel <krystian.hebel@xxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Rich Persaud <persaur@xxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>
- Delivery-date: Tue, 19 Jan 2021 14:58:29 +0000
- Ironport-sdr: s++miZYxC6NJIl1iinYg9Hcr6X8QBy5uHzSr0T4cVcvGVwM2FvWNzdiGVs0K3q2fCNUxBeHuBn QFUhqpoXz2mBuSKJEW4ZnSQy29WHvuBVDja3cnnZ+P0oU/UGU0ate1EbUxgWAH5yDPdTPUX2ah cR8wDAKLdCpxu2bwY2HbW/7mqgIWEAZmkBxyEn3phTeFvBpOKXWKW2+mX5v2mPa+zTl+TjqJdX V6ftwZiCu7iV2erwf0T7/+VliukH4vmYbCLtbQyfPPcHBN1RWz0CIMBv7Ln82PllqlTOPyPlJ1 mwU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Jan 15, 2021 at 11:10:45PM +0000, Andrew Cooper wrote:
> A subsequent change is going to introduce SKINIT support, wherein the APs will
> be already be in the wait-for-SIPI state, and an INIT must not be sent.
>
> Introduce a send_INIT boolean, so we can control sending an INIT IPI
> separately from sending SIPIs.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I'm not opposed to introduce this, but maybe it would be better to
move it to a separate helper? send_init(unsigned int apicid); or some
such?
Would reduce one level of indentation.
Thanks, Roger.
|
