[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] x86/smpboot: Allow making an INIT IPI conditional
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 19 Jan 2021 15:05:38 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ldfb+FlYk9elc/fhYFG9ciL8xX5HRSR/ddujdzXtX9o=; b=gYsvrVf9anhiwNBUk3+SH2IHfDT7Rs/RZDkKTVbMEFTUj89J2kGduG7FwxQUYl5OpBjCymDU4PtfrBQH7JtN4Ert8r6cOApnESHB8OHIItytaGdB9nlqU8IFkn4C8oVERAr32c0/3V63Qx5AU3km1Kj4Xr0ii5lJ7pYGbwNdwzCi9PB+vdjZ2g53KdGR5Ra+w9Q+JILXx+90hGNKbc7AOUWMNZmbs5JEK0LqeM88iH/7z28FoY/EGKt+YyB4cxnQOjX3Cop6fpndLdhwm1qASZs8VKLgOGvHpSHuocbqOq8WQ1W0J8MtHeEHh1iPfgTBlFgjAZaf6zuOyq9pUwjmwg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IC543+8jTGXRoUprMQJn09I5bTDnZEFNGo/ZtzuEysf58Bx/vRWu95aK4QP0SrAH0pq+Hy80XLXsAUVCs53ioxYCNdaMpvr/iXn5n/wtsnZlHmeElEMnv2pv0XQXvBXKJ85P1pY8zc0GAztITEqkUFruHKWAT85rNNBRhd9CBc46MTcEwCis5nam+9MC7RZLbrYhR/7ylTNma8ySVkSvKub4bDKvK8vpnumT3/PWpupKMOHBweqsSNXzzWFXJPen23lXIDvEj+iXOL4/n/wurQqzFV133fi1txAJRaamZymUO/Cpim1krPiua3y8dcSxYBL8Xo3dhH6NP0w9gf7aag==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Kasiewicz <marek.kasiewicz@xxxxxxxxx>, Norbert Kamiński <norbert.kaminski@xxxxxxxxx>, Michal Zygowski <michal.zygowski@xxxxxxxxx>, Piotr Krol <piotr.krol@xxxxxxxxx>, Krystian Hebel <krystian.hebel@xxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Rich Persaud <persaur@xxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>
- Delivery-date: Tue, 19 Jan 2021 15:06:23 +0000
- Ironport-sdr: nBSAy65ISpew0MFuEPXM7uFB4ZLRDS+zPyaZ2XILNM1VyJ+Bqfz1IBsOcJmpfGPuKlA3dEzlTm xSTRbYIP+0hl/NbR75i3kwkXA+il+KY5nA6quf52w9AtpP/6SM3eLYseJp///dM20ix/XfaWNi j8r+Fa3swXk3o2wV+CIHEw8Sv0ZQghn9ZeVYCwp+gJNr2oRlCNNVmMuIfYWyf4uwfKWGZ3em0v LkIo6dsaIa/FcVdQ9wXYxGnoVVXmcuTmgdfwK6T1kqClUGFkEJBwBFX77nzevL/KWNOGyqSdur 2tU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/01/2021 14:58, Roger Pau Monné wrote:
> On Fri, Jan 15, 2021 at 11:10:45PM +0000, Andrew Cooper wrote:
>> A subsequent change is going to introduce SKINIT support, wherein the APs
>> will
>> be already be in the wait-for-SIPI state, and an INIT must not be sent.
>>
>> Introduce a send_INIT boolean, so we can control sending an INIT IPI
>> separately from sending SIPIs.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> I'm not opposed to introduce this, but maybe it would be better to
> move it to a separate helper? send_init(unsigned int apicid); or some
> such?
>
> Would reduce one level of indentation.
I've got a lot of cleanup planned for 4.16, but splitting this up
INIT-SIPI-SIPI is specifically not one of them.
This will get more complicated with Intel TXT Intel, and I also want to
integrate it more nicely with the virtualised AP boot logic. I suspect
we'll end up with a function pointer per platform&configuration, but
that's too much work at this point in 4.15.
~Andrew
|
