[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/smpboot: Re-position the call to tboot_wake_ap()
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 19 Jan 2021 14:55:28 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZA8qkJKQq4jQtEtdpZCmsdJcQhmWp2s/10KBfKZOw0=; b=XFF6ONRFiJoUXuEf9N7kG6XV52vOqU2jHx48i6KK+m+AQAl73Xq/wti4dnln8YKO610Wwxl3ggVN3JqOij4QkwwTaRHMGWeufNCa90ieUQKflNytY/lo3tA0RcNPbnJWw0/bNaZjpxxOrCsZEVJT1sWQmE9w0sJF7fxob9aAVmIq5f2en1cH454bzCr/YjD/UKipciFNNCB5gIcmulkz/08Q8bvnaHBYGhn/YwVJ0q3tRpBt4E/OzSrOjrwJtuPo9KZxRzKJ3TUWq7cctVAJWseaX1L13SROhhCpBEutwKG1aZ6aPfZXObNNrM1nlHWGZYs/gNmSszhjzGQrBP8ebw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KXFenhgUDy4TOhCm8J4bXMdVOf0n/oCh1AZ894J/eYLiifeNTtSjxVSGouF9d2rLMPkKS2hfexi3vsTC9DgifGxX6qoFXPMz1PwU/PsAQ9H0+hQmy8lNpyayD1bQQudfXtCBOJqUonwxvbSdqUDkab961nYu3jH4fkZ+5RP8G0ZvgxpSuegi7YRUhSymg5HYH44GCDpN5MmJLL8E9EI6ye44UT0Fh7LatCPmLZ77SGU4u66w13maWH2Vi5nPe+582kyKk0ao6Q00q1MRL3qGZ2vblXcFwX0UbadETmr/UG2TZpSII7pEbMbgRM7A6ilB9asCWcgDimngd17xm4V9XQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Kasiewicz <marek.kasiewicz@xxxxxxxxx>, Norbert Kamiński <norbert.kaminski@xxxxxxxxx>, Michal Zygowski <michal.zygowski@xxxxxxxxx>, Piotr Krol <piotr.krol@xxxxxxxx>, Krystian Hebel <krystian.hebel@xxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Rich Persaud <persaur@xxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>
- Delivery-date: Tue, 19 Jan 2021 14:55:47 +0000
- Ironport-sdr: hFrJPRHN9y6oGFcWxFmEaiA/CUiSm/xxXQ94HJxBUSNxQICPlDWXH9rk8yAyjodzc4KLE/nSe7 WGp9H0zPlg+39uHg27gFRjY52vwhU9YF7CYU2Gn1yDTTvIlRnIjepCBuxiF6Ls60/BZCBEKA3T r6lV6HJ2ajFHo1+Zv6ShL5Z/MX8bNgms2G1oAPeR5pT4mv/QWxNKm5Ym4ym/3GKI2HWLpsnqEM 9Sw2L8mO90zDnrrw8VQtiHDf0Hgn00NTCeZ3+38J65rmvSqPby8UiJXJl4muGy2lcqx+kHP5R6 gQA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/01/2021 14:38, Roger Pau Monné wrote:
> On Fri, Jan 15, 2021 at 11:10:44PM +0000, Andrew Cooper wrote:
>> So all the moving parts are in one function.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Marek Kasiewicz <marek.kasiewicz@xxxxxxxxx>
>> CC: Norbert Kamiński <norbert.kaminski@xxxxxxxxx>
>> CC: Michal Zygowski <michal.zygowski@xxxxxxxxx>
>> CC: Piotr Krol <piotr.krol@xxxxxxxx>
>> CC: Krystian Hebel <krystian.hebel@xxxxxxxxx>
>> CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
>> CC: Rich Persaud <persaur@xxxxxxxxx>
>> CC: Christopher Clark <christopher.w.clark@xxxxxxxxx>
>> ---
>> xen/arch/x86/smpboot.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
>> index 67e727cebd..9eca452ce1 100644
>> --- a/xen/arch/x86/smpboot.c
>> +++ b/xen/arch/x86/smpboot.c
>> @@ -426,6 +426,13 @@ static int wakeup_secondary_cpu(int phys_apicid,
>> unsigned long start_eip)
>> int maxlvt, timeout, i;
>>
>> /*
>> + * Some versions of tboot might be able to handle the entire wake
>> sequence
>> + * on our behalf.
>> + */
>> + if ( tboot_in_measured_env() && tboot_wake_ap(phys_apicid, start_eip) )
> I think you are missing a ! in front of tboot_wake_ap?
Oh - so I am. That function is totally backwards.
Fixed.
~Andrew
|
