Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.17 at 22:40, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -2259,7 +2259,7 @@ void free_domheap_pages(struct page_info *pg, unsigned 
> int order)
>               */
>              scrub = !!d->is_dying;
>  #else
> -            scrub = true;
> +            scrub = boot_scrub_done || !!d->is_dying;
>  #endif

Actually Wei has a point here - already when reviewing the original
series I had wondered whether a "#define boot_scrub_done false"
in the non-debug case wouldn't help eliminate some #ifdef-ary.
Here it would mean fulfilling Wei's request indirectly, by simply
removing the preprocessor directives altogether.

In any event the !! is pointless on an operand to || or && .

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel