Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 29, 2017 at 07:26:28AM -0600, Jan Beulich wrote:
> >>> On 28.08.17 at 22:40, <boris.ostrovsky@xxxxxxxxxx> wrote:
> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -2259,7 +2259,7 @@ void free_domheap_pages(struct page_info *pg, 
> > unsigned int order)
> >               */
> >              scrub = !!d->is_dying;
> >  #else
> > -            scrub = true;
> > +            scrub = boot_scrub_done || !!d->is_dying;
> >  #endif
> 
> Actually Wei has a point here - already when reviewing the original
> series I had wondered whether a "#define boot_scrub_done false"
> in the non-debug case wouldn't help eliminate some #ifdef-ary.
> Here it would mean fulfilling Wei's request indirectly, by simply
> removing the preprocessor directives altogether.

This SGTM

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel