Re: [Xen-devel] [PATCH v2 4/6] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.17 at 16:24, <george.dunlap@xxxxxxxxxx> wrote:
> On 08/28/2017 09:29 AM, Jan Beulich wrote:
>>>>> On 27.08.17 at 10:36, <blackskygg@xxxxxxxxx> wrote:
>>> --- a/xen/arch/arm/mm.c
>>> +++ b/xen/arch/arm/mm.c
>>> @@ -1284,7 +1284,7 @@ int xenmem_add_to_physmap_one(
>>>              return -EINVAL;
>>>          }
>>>  
>>> -        rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od);
>>> +        rc = xsm_map_gmfn_foreign(XSM_TARGET, current->domain, d, od);
>>>          if ( rc )
>>>          {
>>>              rcu_unlock_domain(od);
>>> --- a/xen/arch/x86/mm/p2m.c
>>> +++ b/xen/arch/x86/mm/p2m.c
>>> @@ -2545,7 +2545,7 @@ int p2m_add_foreign(struct domain *tdom, unsigned 
>>> long fgfn,
>>>      if ( tdom == fdom )
>>>          goto out;
>>>  
>>> -    rc = xsm_map_gmfn_foreign(XSM_TARGET, tdom, fdom);
>>> +    rc = xsm_map_gmfn_foreign(XSM_TARGET, current->domain, tdom, fdom);
>> 
>> I continue to dislike the added arguments here, as being pointless
>> to pass. I'm not the maintainer of either of the modified files, so I
>> won't (and can't) veto the change though.
> 
> You mean, you think xsm_map_gmfn_foreign() can look up 'current' itself?

Yes, that's what I had suggested before (in more detail than I
have given here); I also don't think it would be
xsm_map_gmfn_foreign(), but rather whatever functions back
it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel