Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/08/16 09:01, Jan Beulich wrote:
> Non-debugging message text should be (and is here) distinguishable
> without also logging function names.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
>          peek = 0;
>  
>      if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
> -        printk("%s: %d failed page allocs while logging dirty pages\n",
> -               __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
> +        printk(XENLOG_WARNING
> +               "%u failed page allocs while logging dirty pages of Dom%d\n",
> +               d->arch.paging.log_dirty.failed_allocs, d->domain_id);

Can we standardise on d%d instead?  It is shorter, and mutually
consistent with d%dv%d for vcpus.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel