Re: [Xen-devel] [PATCH] pass-through: drop pointless uses of __func__

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/08/16 08:51, Jan Beulich wrote:
> Non-debugging message text should be (and is in the cases here)
> distinguishable without also logging function names. Additionally log
> the PCI device coordinates for alloc_pdev() failure.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

On this note, I have a series I never really started properly, which
introduces a single pci_sbdf_t, totalling 32 bits of bitfields, and a
custom %p handler.  The register shuffling required in all the function
calls taking 4 parameters for the PCI SBDF which total 32 bits seems
extremely wasteful.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel