Re: [Xen-devel] [PATCH] pass-through: drop pointless uses of __func__

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Aug 24, 2016 at 01:51:13AM -0600, Jan Beulich wrote:
> Non-debugging message text should be (and is in the cases here)
> distinguishable without also logging function names. Additionally log
> the PCI device coordinates for alloc_pdev() failure.
> 

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -379,8 +379,8 @@ static struct pci_dev *alloc_pdev(struct
>              break;
>  
>          default:
> -            printk(XENLOG_WARNING "%s: unknown type: %04x:%02x:%02x.%u\n",
> -                   __func__, pseg->nr, bus, PCI_SLOT(devfn), 
> PCI_FUNC(devfn));
> +            printk(XENLOG_WARNING "%04x:%02x:%02x.%u: unknown type %d\n",
> +                   pseg->nr, bus, PCI_SLOT(devfn), PCI_FUNC(devfn), 
> pdev->type);
>              break;
>      }
>  
> @@ -991,7 +991,8 @@ static int __init _scan_pci_devices(stru
>                  pdev = alloc_pdev(pseg, bus, PCI_DEVFN(dev, func));
>                  if ( !pdev )
>                  {
> -                    printk("%s: alloc_pdev failed.\n", __func__);
> +                    printk(XENLOG_WARNING "%04x:%02x:%02x.%u: alloc_pdev 
> failed\n",
> +                           pseg->nr, bus, dev, func);
>                      return -ENOMEM;
>                  }
>  
> 
> 
> 

> pass-through: drop pointless uses of __func__
> 
> Non-debugging message text should be (and is in the cases here)
> distinguishable without also logging function names. Additionally log
> the PCI device coordinates for alloc_pdev() failure.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -379,8 +379,8 @@ static struct pci_dev *alloc_pdev(struct
>              break;
>  
>          default:
> -            printk(XENLOG_WARNING "%s: unknown type: %04x:%02x:%02x.%u\n",
> -                   __func__, pseg->nr, bus, PCI_SLOT(devfn), 
> PCI_FUNC(devfn));
> +            printk(XENLOG_WARNING "%04x:%02x:%02x.%u: unknown type %d\n",
> +                   pseg->nr, bus, PCI_SLOT(devfn), PCI_FUNC(devfn), 
> pdev->type);
>              break;
>      }
>  
> @@ -991,7 +991,8 @@ static int __init _scan_pci_devices(stru
>                  pdev = alloc_pdev(pseg, bus, PCI_DEVFN(dev, func));
>                  if ( !pdev )
>                  {
> -                    printk("%s: alloc_pdev failed.\n", __func__);
> +                    printk(XENLOG_WARNING "%04x:%02x:%02x.%u: alloc_pdev 
> failed\n",
> +                           pseg->nr, bus, dev, func);
>                      return -ENOMEM;
>                  }
>  

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel