Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Aug 24, 2016 at 02:01:09AM -0600, Jan Beulich wrote:
> Non-debugging message text should be (and is here) distinguishable
> without also logging function names.

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
>          peek = 0;
>  
>      if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
> -        printk("%s: %d failed page allocs while logging dirty pages\n",
> -               __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
> +        printk(XENLOG_WARNING
> +               "%u failed page allocs while logging dirty pages of Dom%d\n",
> +               d->arch.paging.log_dirty.failed_allocs, d->domain_id);
>          rv = -ENOMEM;
>          goto out;
>      }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel