Re: [Xen-devel] [PATCH] x86: drop pointless uses of __func__ / __FUNCTION__

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/08/16 09:02, Jan Beulich wrote:
> Non-debugging message text should be (and is in the cases here)
> distinguishable without also logging function names. Debugging message
> text, otoh, already includes file name and line number, so also
> logging function names is redundant. One relatively pointless debugging
> message gets removed altogether. In another case a mising log level
> specifier gets added at once.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/io_apic.c
> +++ b/xen/arch/x86/io_apic.c
> @@ -2307,14 +2307,12 @@ int ioapic_guest_read(unsigned long phys
>      return 0;
>  }
>  
> -#define WARN_BOGUS_WRITE(f, a...)                       \
> -    dprintk(XENLOG_INFO, "\n"                           \
> -            XENLOG_INFO "%s: apic=%d, pin=%d, irq=%d\n" \
> -            XENLOG_INFO "%s: new_entry=%08x\n"          \
> -            XENLOG_INFO "%s: " f "\n",                  \
> -            __func__, apic, pin, irq,                   \
> -            __func__, *(u32 *)&rte,                     \
> -            __func__, ##a )
> +#define WARN_BOGUS_WRITE(f, a...)                            \
> +    dprintk(XENLOG_INFO, "\n"                                \

I would be tempted to get rid of this stray newline entirely.  It serves
no useful purpose.

Alternatively, the literal "BOGUS WRITE\n" would be an improvement.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel