Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new rdm policy parameters

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-07-13 at 17:55 +0800, Chen, Tiejun wrote:
> On 2015/7/13 17:40, Ian Campbell wrote:
> > On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
> >> I still can't understand what I'm missing here after compared to other
> >> contexts inside xlu_pci_parse_bdf().
> >
> > Perhaps comparing to the CODING_STYLE document would help?
> 
> Looks the whole xlu_pci_parse_bdf() doesn't follow that,
> 
>                  if ( !strcmp(optkey, "msitranslate") ) {
>                      pcidev->msitranslate = atoi(tok);
>                  }else if ( !strcmp(optkey, "power_mgmt") ) {
>                      pcidev->power_mgmt = atoi(tok);
>                  }else if ( !strcmp(optkey, "permissive") ) {
>                      pcidev->permissive = atoi(tok);
>                  }else if ( !strcmp(optkey, "seize") ) {
>                      pcidev->seize = atoi(tok);
>                  }else if ( !strcmp(optkey, "rdm_policy") ) {
> 
> So I can do this as you're expecting now, but seems our change would 
> make the code style very inconsistent inside this function.

I think one could make an argument that the exception described in the
first section of tools/libxl/CODING_STYLE applies here for the
whitespace issues, but not for the long lines I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel