Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new rdm policy parameters

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
> I still can't understand what I'm missing here after compared to other 
> contexts inside xlu_pci_parse_bdf().

Perhaps comparing to the CODING_STYLE document would help?

>  So I have to paste this entirely,
> 
>                  }else if ( !strcmp(optkey, "rdm_policy") ) {

Should be:
                 } else if (!strcmp(optkey, "rdm_policy")) {

i.e. space after } before "else" and no extra spaces inside the if
condition.

>                      if ( !strcmp(tok, "strict") ) {

                     if (!strcmp(tok, "strict")) {

Again no spaces within the if.

>                          pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_STRICT;
>                      }else if ( !strcmp(tok, "relaxed") ) {

Again add a space after } and remove those inside the if condition.

>                          pcidev->rdm_policy = 
> LIBXL_RDM_RESERVE_POLICY_RELAXED;
>                      }else{

Should be:
                     } else {

>                          XLU__PCI_ERR(cfg, "%s is not an valid PCI RDM 
> property"
>                                            " policy: 'strict' or 
> 'relaxed'.",
>                                       tok);
>                          goto parse_error;
>                      }
>                  }else{

and again "} else {"

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel