[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/5] x86: widen NUMA nodes to be allocated from

On Fri, 2015-02-27 at 13:36 +0000, Jan Beulich wrote:
> >>> On 27.02.15 at 14:27, <dario.faggioli@xxxxxxxxxx> wrote:

> > I'm asking because I really don't like vcpu_to_node(). And I'm not
> > talking about how it is implemented (there probably are not much
> > alternatives), I'm saying I don't think it should exist, and I really
> > would see value in killing it. :-)
> I'm all for killing it. In fact I'd also like to see domain_to_node()
> go away, as it's similarly bogus (no matter of the proposed
> changed implementation) - neither a vCPU nor a domain have
> a "focus" node or some such (some may happen to if their node
> mask has just a single set bit, but that's nothing code should
> depend on). 
I totally agree. I didn't go as far as far as suggesting that because,
if my grep-ing is not failing, it's still in use in two more places,
even with your series applied.

But yes, we really should make it possible to remove it too.

> (And btw, at the very least first_node() in your
> proposal should become any_node().)
Except, there is no such function. But again, I agree, and if we get to
the point where we can kill vcpu_to_node() but need to keep
domain_to_node, we can of course implement it. :-)


Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.