Re: [Xen-devel] [PATCH 3/5] x86: widen NUMA nodes to be allocated from

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2015-02-26 at 13:54 +0000, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

One question (a genuine one, i.e., I'm really not sure what I'm saying
is correct).

After this series, vcpu_to_node() (defined in xen/include/xen/numa.h) is
left with only one use, in xen/arch/arm/domain.c, besides of course
being used to implement domain_to_node() (still in
xen/include/xen/numa.h).

So, provided ARM people (and I'm Cc-ing them) can get rid of that, can
that macro be removed all together, and domain_to_node(d) be defined
after d->node_affinity... something like:

 #define domain_to_node(d) \
   ( nodes_equal(d->node_affinity, NODE_MASK_ALL) \
     ? NUMA_NO_NODE : first_node(d->node_affinity) ) 

I'm asking because I really don't like vcpu_to_node(). And I'm not
talking about how it is implemented (there probably are not much
alternatives), I'm saying I don't think it should exist, and I really
would see value in killing it. :-)

Thoughts?

Thanks and Regards,
Dario

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel