[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/5] x86: widen NUMA nodes to be allocated from

>>> On 27.02.15 at 14:27, <dario.faggioli@xxxxxxxxxx> wrote:
> One question (a genuine one, i.e., I'm really not sure what I'm saying
> is correct).
> After this series, vcpu_to_node() (defined in xen/include/xen/numa.h) is
> left with only one use, in xen/arch/arm/domain.c, besides of course
> being used to implement domain_to_node() (still in
> xen/include/xen/numa.h).
> So, provided ARM people (and I'm Cc-ing them) can get rid of that, can
> that macro be removed all together, and domain_to_node(d) be defined
> after d->node_affinity... something like:
>  #define domain_to_node(d) \
>    ( nodes_equal(d->node_affinity, NODE_MASK_ALL) \
>      ? NUMA_NO_NODE : first_node(d->node_affinity) ) 
> I'm asking because I really don't like vcpu_to_node(). And I'm not
> talking about how it is implemented (there probably are not much
> alternatives), I'm saying I don't think it should exist, and I really
> would see value in killing it. :-)

I'm all for killing it. In fact I'd also like to see domain_to_node()
go away, as it's similarly bogus (no matter of the proposed
changed implementation) - neither a vCPU nor a domain have
a "focus" node or some such (some may happen to if their node
mask has just a single set bit, but that's nothing code should
depend on). (And btw, at the very least first_node() in your
proposal should become any_node().)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.