[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: Minor modifications to platform.h to make it C++-friendly

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Mon, 23 Feb 2015 13:05:48 +0200
  • Cc: tim@xxxxxxx, xen-devel@xxxxxxxxxxxxx, keir@xxxxxxx, ian.jackson@xxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Mon, 23 Feb 2015 11:04:46 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=OTtAcLYFHHIUPGFndMhmCZoXpzVQRgPR4OSwvT609DljCMG9KbQ6VxfwCsZ8YPIXu73vrOya4EFWG0b6xqQF1dURiq+/9j2/Cu8j+Aau85uTSuO9EsqaGcfnixQJIC78FEKbl1MlDTgyAEb7kecQQ2LbzLIYdv5VCJYSMl1LoUo6HVKGMqx43Lf1g8gUYBa/idOxjcme+ZdN3hDbNzzohwLSirjTU+7Q+sL+ON3ivgeZhQGHiMF81RmbnGDLdySVr1yVU6LD9RKt9RTcpkARjfcjrV/qHoSZ6B8wcDjL3LHpOBLhZ91sqlDhptHGSKj9OOs/nAvebNoIGoJh6J+oYw==; h=Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 02/23/2015 12:54 PM, Jan Beulich wrote:
>>>> @@ -152,24 +159,24 @@ struct xenpf_efi_runtime_call {
>>>>      xen_ulong_t status;
>>>>      union {
>>>>  #define XEN_EFI_GET_TIME_SET_CLEARS_NS 0x00000001
>>>> +        struct xenpf_efi_time {
>>>> +            uint16_t year;
>>>> +            uint8_t month;
>>>> +            uint8_t day;
>>>> +            uint8_t hour;
>>>> +            uint8_t min;
>>>> +            uint8_t sec;
>>>> +            uint32_t ns;
>>>> +            int16_t tz;
>>>> +            uint8_t daylight;
>>>> +        } set_time;
>>>> +
> ... this should be moved out to file scope too, both for consistency
> and to avoid an eventual further adjustment going forward. Otoh
> I'm not convinced we need the headers to be C++ ready (nor am
> I convinced that there aren't any other obstacles preventing their
> unmodified use in C++). Co-maintainers, what do you think?

You're right, it's always better to be consistent. Will do.

As for the headers being C++ ready, there's already the precedent of at
least my previous patch "xenctrl: Make the headers C++ friendly":


where it turned out that there's at least one other serious user of Xen
with C++, Don Slutz.

I do understand and respect the fact that C++ is not a xen-devel target,
but I also believe that there are a very small number of changes that
could enlarge the Xen user base to include C++ developers, and that it
can be done in completely painless manner for all involved.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.