Re: [Xen-devel] [PATCH] xen: Minor modifications to platform.h to make it C++-friendly

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.15 at 12:05, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> As for the headers being C++ ready, there's already the precedent of at
> least my previous patch "xenctrl: Make the headers C++ friendly":
> 
> http://www.gossamer-threads.com/lists/xen/devel/337788 
> 
> where it turned out that there's at least one other serious user of Xen
> with C++, Don Slutz.

That's a different story - we're talking about the canonical public
headers here.

> I do understand and respect the fact that C++ is not a xen-devel target,
> but I also believe that there are a very small number of changes that
> could enlarge the Xen user base to include C++ developers, and that it
> can be done in completely painless manner for all involved.

No, if you want to do just that, it's going to get broken again. If we
want the headers to be C++ ready, we ought to introduce a build
time check similar to the one checking that they're plain ANSI C
conforming. Which in turn, as a prerequisite, would need you to
make sure they _all_ are usable in C++. (Such a build time check,
in case you want to propose an extended series, should of course
be conditional upon there being a C++ compiler available - we
clearly don't want to enforce its installation onto everyone
consuming Xen, even if we expect developers to have it installed
in order for them to make sure their patches don't introduce build
breakage).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel