Re: [Xen-devel] Blocking CR and MSR writes via mem_access?

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 10/07/2014 03:40 PM, Jan Beulich wrote:
>>>> On 07.10.14 at 14:30, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> IMHO that entire struct is in dire need of a cleanup. It is really hacky to
>> have fields like gla and gfn transfer values that mean different things
>> under different event type that don't have anything to do with gla/gfn.
>> It's sort of just a legacy struct from the time when we only had EPT events
>> and everything else just got hacked on top. I would be in favor of having
>> the struct as a union of substructs that nicely define all the values that
>> are transferred in the given context, with meaningful struct member names.
> 
> And the whole thing isn't just "mem-event" anymore either ...

I agree with the union improvement, and indeed, we might need a more
appropriate name for the whole thing (xen-event?).

I guess one question would be how this would impact existing clients,
but there probably aren't that many, and the changes required to replace
the .gla / .gfn logic should be minimal.


Thanks,
Razvan Cojocaru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel