Re: [Xen-devel] [PATCH v3] xen/arm: Fix crash if last memory section is bigger than 1gb

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-10-03 at 11:15 +0100, Frediano Ziglio wrote:
> 2014-10-03 10:09 GMT+01:00 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > On Thu, 2014-10-02 at 16:16 +0100, Frediano Ziglio wrote:
> >> setup_xenheap_mappings setup head memory on Arm 32 has a limit of 1gb.
> >> On system with large memory is possible that there are no blocks of memory
> >> smaller than 1gb leading xenheap_pages to be more than 1gb.
> >> This cause memory errors trying to access heap after the 1gb limit.
> >
> > As I mentioned in a previous round of review this explanation doesn't
> > really fit.
> >
> > I think better would be:
> >
> >         On arm32 the xenheap has a maximum size of 1GB. On systems with
> >         more than 8GB (so 1/8 total RAM is greater than 1GB) there is no
> >         point in searching for a region with 1/8 of the total RAM when
> >         only 1GB will be used. Therefore limit the maximum size to 1GB
> >         before searching.
> >
> > If you agree I will make this change upon commit.
> >
> 
> Agree. This explains the real reason of the change.

Acked + applied with this new text. Thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel