Re: [Xen-devel] [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/09/14 16:04, Ian Campbell wrote:
> On Mon, 2014-09-08 at 14:24 -0700, Julien Grall wrote:
>>> +    /* mappings[root_level] is provided by the caller so don't unmap that 
>>> */
>>> +    do
>>> +    {
>>> +        unmap_domain_page(mappings[level]);
>>> +    }
>>> +    while( level-- > root_level );
>> NIT: It looks like we commonly use the coding style
>>
>> do
>> {
>> } while ( ... )
> Seems we do. Seems inconsistent with if() and while/do loops to me. Oh
> well.
>
> Ian.

It is to visually differentiate

if ( ... )
{
    ....
}
while ( something unrelated, with a suspicious looking semicolon );

from
do
{
    ....
}
while ( something related to the loop );

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel