Re: [Xen-devel] [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-09 at 16:04 +0100, Ian Campbell wrote:
> On Mon, 2014-09-08 at 14:24 -0700, Julien Grall wrote:
> > > +    /* mappings[root_level] is provided by the caller so don't unmap 
> > > that */
> > > +    do
> > > +    {
> > > +        unmap_domain_page(mappings[level]);
> > > +    }
> > > +    while( level-- > root_level );
> > 
> > NIT: It looks like we commonly use the coding style
> > 
> > do
> > {
> > } while ( ... )
> 
> Seems we do. Seems inconsistent with if() and while/do loops to me. Oh
> well.

Actually now I go to look for the line in question it seems like we
actually have a pretty arbitrary mixture. I'm going to stick with the
extra newline (I did fix the missing space after the while though).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel